zsh-workers
 help / color / mirror / code / Atom feed
* zsh autocompletion not quite right for "sccs delget"
@ 2011-02-13 17:11 Sebastien Roy
  2011-02-15 18:50 ` Peter Stephenson
  0 siblings, 1 reply; 2+ messages in thread
From: Sebastien Roy @ 2011-02-13 17:11 UTC (permalink / raw)
  To: zsh-workers

Hi folks,

I'm running zsh 4.3.10, and the "sccs delget <file>" command doesn't do 
autocompletion on the file argument.  This is in contrast with other 
sccs subcommands (e.g. diffs, create, etc.), which correctly do this.

It appears that there's a files argument missing from the delget entry 
in the Completion/Unix/_sccs completion file:

   sact|print) _sccs_files;;
   create|enter) _files;;
   deledit|delget|delta)
     _arguments '-s[silent]' '-y+[specify delta commentary]:comment'
   ;;
   diffs)
     _diff_options diff "$sfiles" "$ropt" "$copt" \
       '-C[output a context diff]'
   ;;

-Seb


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: zsh autocompletion not quite right for "sccs delget"
  2011-02-13 17:11 zsh autocompletion not quite right for "sccs delget" Sebastien Roy
@ 2011-02-15 18:50 ` Peter Stephenson
  0 siblings, 0 replies; 2+ messages in thread
From: Peter Stephenson @ 2011-02-15 18:50 UTC (permalink / raw)
  To: zsh-workers

On Sun, 13 Feb 2011 12:11:51 -0500
Sebastien Roy <sebastien.roy@oracle.com> wrote:
> I'm running zsh 4.3.10, and the "sccs delget <file>" command doesn't do 
> autocompletion on the file argument.

Presumably the fix is something like the following, though I never use
sccs and don't really know what the different file completions are, and
it's using _arguments slightly differently from the way most functions do.

Index: Completion/Unix/Command/_sccs
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Unix/Command/_sccs,v
retrieving revision 1.6
diff -p -u -r1.6 _sccs
--- Completion/Unix/Command/_sccs	21 Jan 2004 13:53:29 -0000	1.6
+++ Completion/Unix/Command/_sccs	15 Feb 2011 18:48:32 -0000
@@ -109,7 +109,9 @@ case $service in
   sact|print) _sccs_files;;
   create|enter) _files;;
   deledit|delget|delta)
-    _arguments '-s[silent]' '-y+[specify delta commentary]:comment'
+    _arguments "$sfiles" \
+	'-s[silent]' \
+	'-y+[specify delta commentary]:comment' \
   ;;
   diffs)
     _diff_options diff "$sfiles" "$ropt" "$copt" \

-- 
Peter Stephenson <p.w.stephenson@ntlworld.com>
Web page now at http://homepage.ntlworld.com/p.w.stephenson/


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-02-15 18:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-02-13 17:11 zsh autocompletion not quite right for "sccs delget" Sebastien Roy
2011-02-15 18:50 ` Peter Stephenson

Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).