From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: Zsh list <zsh-workers@zsh.org>
Subject: Re: PATCH: zstyle to control completion of functions/parameters beginning with underscore
Date: Tue, 1 Mar 2011 21:11:57 +0000 [thread overview]
Message-ID: <20110301211157.0bf72ae1@pws-pc.ntlworld.com> (raw)
In-Reply-To: <m3ei6qvalg.fsf_-_@klanderman.net>
On Tue, 01 Mar 2011 15:39:55 -0500
Greg Klanderman <gak@klanderman.net> wrote:
> >>>>> On May 28, 2009 Richard Hartmann <richih.mailinglist@gmail.com> wrote:
> > On Wed, May 27, 2009 at 21:12, Greg Klanderman <gak@klanderman.net> wrote:
> >> But in the same vein, what I really want is a way to configure the
> >> behavior for functions, variables, etc. beginning with "_" to be like
> >> filenames beginning with ".": completion should work if I have
> >> explicitly typed the leading "_", but even substring matching should
> >> not *generate* a leading "_".
>
> > I think this is a good explanation of what, imo, the final goal should be.
>
> What do you guys think of the patch below? I'm open to better names
> for the zstyle.. I've tested it a fair amount locally.
Looks good to me.
I think you missed the following case...
Index: Completion/Zsh/Type/_functions
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Zsh/Type/_functions,v
retrieving revision 1.3
diff -p -u -r1.3 _functions
--- Completion/Zsh/Type/_functions 8 Jun 2005 12:45:36 -0000 1.3
+++ Completion/Zsh/Type/_functions 1 Mar 2011 21:10:13 -0000
@@ -1,5 +1,15 @@
#compdef unfunction
-local expl
+local expl hide ffilt
-_wanted functions expl 'shell function' compadd -k "$@" - functions
+zstyle -s ":completion:${curcontext}:functions" hide-internal hide
+case "${hide:-never}" in
+ no|false|never)
+ ffilt='';;
+ yes|true|always)
+ ffilt='[(I)[^_.]*]';;
+ auto|dtrt)
+ [[ $PREFIX = [_.]* ]] && ffilt='' || ffilt='[(I)[^_.]*]';;
+esac
+
+_wanted functions expl 'shell function' compadd -k "$@" - "functions$ffilt"
--
Peter Stephenson <p.w.stephenson@ntlworld.com>
Web page now at http://homepage.ntlworld.com/p.w.stephenson/
next prev parent reply other threads:[~2011-03-01 21:49 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-05 0:07 PATCH: Add CORRECT_NOCOMPSYS option Frank Terbeck
2009-04-05 2:37 ` Bart Schaefer
2009-04-05 12:23 ` Frank Terbeck
2009-04-05 18:13 ` Peter Stephenson
2009-04-05 22:11 ` Bart Schaefer
2009-04-06 9:09 ` Peter Stephenson
2009-05-27 16:30 ` Richard Hartmann
2009-05-27 16:59 ` Peter Stephenson
2009-05-27 19:12 ` Greg Klanderman
2009-05-28 8:48 ` Richard Hartmann
2009-05-28 9:25 ` Frank Terbeck
2009-05-28 18:44 ` Greg Klanderman
2009-05-28 19:03 ` Frank Terbeck
2009-05-28 19:35 ` Peter Stephenson
2009-05-28 22:56 ` Greg Klanderman
2009-05-29 8:32 ` Peter Stephenson
2009-05-29 14:38 ` Greg Klanderman
2009-05-29 14:49 ` Peter Stephenson
2011-03-01 20:39 ` PATCH: zstyle to control completion of functions/parameters beginning with underscore Greg Klanderman
2011-03-01 21:11 ` Peter Stephenson [this message]
2011-03-01 22:07 ` Greg Klanderman
2011-03-02 1:05 ` Oliver Kiddle
2011-03-02 18:49 ` Greg Klanderman
2011-03-02 23:30 ` Bart Schaefer
2011-03-03 15:33 ` Greg Klanderman
2011-03-03 16:11 ` Greg Klanderman
2011-03-03 16:54 ` Bart Schaefer
2011-03-06 20:07 ` Greg Klanderman
2011-03-06 22:02 ` Bart Schaefer
2011-03-08 15:13 ` Greg Klanderman
2011-03-09 18:41 ` Greg Klanderman
2011-03-10 15:54 ` Bart Schaefer
2011-03-10 16:44 ` Greg Klanderman
2011-03-10 17:10 ` Bart Schaefer
2011-03-10 18:01 ` Greg Klanderman
2011-03-11 17:01 ` Greg Klanderman
2011-03-03 16:58 ` Oliver Kiddle
2011-03-02 1:13 ` Richard Hartmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110301211157.0bf72ae1@pws-pc.ntlworld.com \
--to=p.w.stephenson@ntlworld.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).