From: Simon Ruderich <simon@ruderich.org>
To: zsh-workers@zsh.org
Subject: Re: Slowness issue with git completion
Date: Sat, 30 Apr 2011 16:37:18 +0200 [thread overview]
Message-ID: <20110430143718.GA20793@ruderich.org> (raw)
In-Reply-To: <BANLkTimmw3+nWyYS27MzDm-z-rFCT2yxaQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 880 bytes --]
On Wed, Apr 27, 2011 at 02:51:05PM +0200, Nikolai Weibull wrote:
> [snip]
>
> Let’s instead remove it.
>
> The attached patch seems to speed up matching a lot, while maintaining
> all functionality. There might be cases that I haven’t considered.
> Please review.
Seems to work fine for me (haven't tested it thoroughly though,
just normal usage).
However it looks like two __git_files_relative are still there,
in the functions:
__git_changed-in-index_files
__git_changed-in-working-tree_files
But I only noticed it when I tried this:
git commit --am<tab>
__git_changed-in-index_files:5: command not found: __git_files_relative
__git_changed-in-working-tree_files:5: command not found: __git_files_relative
Regards,
Simon
--
+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2011-04-30 14:37 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-26 18:26 Felipe Contreras
2011-04-26 18:43 ` Frank Terbeck
2011-04-26 19:06 ` Nikolai Weibull
2011-04-26 20:10 ` Frank Terbeck
2011-04-26 20:23 ` Felipe Contreras
2011-04-26 20:34 ` Mikael Magnusson
2011-04-26 20:57 ` Felipe Contreras
2011-04-26 20:59 ` Mikael Magnusson
2011-04-26 21:10 ` Felipe Contreras
2011-04-26 21:13 ` Mikael Magnusson
2011-04-26 21:35 ` Felipe Contreras
2011-04-26 22:03 ` Nikolai Weibull
2011-04-26 22:25 ` Felipe Contreras
2011-04-26 23:14 ` Benjamin R. Haskell
2011-04-27 7:01 ` Benjamin R. Haskell
2011-04-27 1:52 ` gi1242+zsh
2011-04-27 6:11 ` Nikolai Weibull
2011-04-27 8:30 ` Felipe Contreras
2011-04-27 8:47 ` Frank Terbeck
2011-04-27 9:06 ` Felipe Contreras
2011-04-27 10:15 ` Nikolai Weibull
2011-04-27 10:42 ` Felipe Contreras
2011-04-27 11:14 ` Nikolai Weibull
2011-04-27 4:19 ` Bart Schaefer
2011-04-27 6:13 ` Nikolai Weibull
2011-04-27 12:51 ` Nikolai Weibull
2011-04-27 14:55 ` Bart Schaefer
2011-04-27 18:36 ` Nikolai Weibull
2011-04-30 14:37 ` Simon Ruderich [this message]
2011-04-30 15:00 ` Simon Ruderich
2011-05-02 9:59 ` Nikolai Weibull
2011-05-03 13:59 ` Nikolai Weibull
2011-04-26 21:52 ` Benjamin R. Haskell
2011-04-26 22:04 ` Felipe Contreras
2011-04-26 22:35 ` Benjamin R. Haskell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110430143718.GA20793@ruderich.org \
--to=simon@ruderich.org \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).