From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5710 invoked by alias); 30 Apr 2011 14:37:45 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 29111 Received: (qmail 17248 invoked from network); 30 Apr 2011 14:37:30 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 Received-SPF: pass (ns1.primenet.com.au: SPF record at ruderich.org designates 178.63.68.96 as permitted sender) Date: Sat, 30 Apr 2011 16:37:18 +0200 From: Simon Ruderich To: zsh-workers@zsh.org Subject: Re: Slowness issue with git completion Message-ID: <20110430143718.GA20793@ruderich.org> References: <87liyw7t0o.fsf@ft.bewatermyfriend.org> <110426211951.ZM4200@torch.brasslantern.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=_zucker.schokokeks.org-30894-1304174241-0001-2" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2011-04-20) --=_zucker.schokokeks.org-30894-1304174241-0001-2 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 27, 2011 at 02:51:05PM +0200, Nikolai Weibull wrote: > [snip] > > Let=E2=80=99s instead remove it. > > The attached patch seems to speed up matching a lot, while maintaining > all functionality. There might be cases that I haven=E2=80=99t considere= d. > Please review. Seems to work fine for me (haven't tested it thoroughly though, just normal usage). However it looks like two __git_files_relative are still there, in the functions: __git_changed-in-index_files __git_changed-in-working-tree_files But I only noticed it when I tried this: git commit --am __git_changed-in-index_files:5: command not found: __git_files_relative __git_changed-in-working-tree_files:5: command not found: __git_files_r= elative Regards, Simon --=20 + privacy is necessary + using gnupg http://gnupg.org + public key id: 0x92FEFDB7E44C32F9 --=_zucker.schokokeks.org-30894-1304174241-0001-2 Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQIcBAEBCAAGBQJNvB6eAAoJEJL+/bfkTDL5AUMP/2ckKRWvXvOWXmuVeQsbROmb 2Xz/vpcVfu33ezeX213pMLlY3JPPeHFdVsYasBi+JiUB38auT+WhyyqKyN1e5plx YDXsXw/Z7UB8jWHq4YchSqKSuwyPn515hQgpYMyRCAI183HgCphISu98Zb/CAFD+ OiqWEnFdMXRA5Y8I2SZi8ULLjWbvGyvbNUC2nB6tweHljI9u8vtgc/pu439IAENT 2D8aEEHPRQyqlaTLlMM9V6hdm7hjS1iK3NE0qaf44fNCD7JZ8FU436D7JpeKa4SF igGlnPTr4LLJROgyJD//vMW74zc42pMePzn7H3rBm0dGB9Zhi7Bl+BVk3WR0uicG q6txHKsRq0N9sKZqk7AjV2iEuQs/ItZVWCYazDNomcd8m/G0MSZQdK9jOjkmy9i8 IHaTHKCZeYzUdHnzHBMji3lPUldFNPkdmLzj5UVSPbXud+SKR3IGJTnv8QlrH1o4 nX51lGOfExBWt0brcsPUIRRrqGbtws3En+tTATR9DBcAczXFOtAaipzMNH3LN1dr ByGB3wYynb+OirFq9lJSjXv7BZe5+B4VXOVdxTrxGPyCfYlBvTXzTv5H6IyFgiYB kNYJLZr5hyMEAKfBSF4xSCJfKHedREUpNX4TXcuUBxcLpuPZkKURoIeC/U/eZa8H 1NEMVvViMjFLBAeQZQem =VlXl -----END PGP SIGNATURE----- --=_zucker.schokokeks.org-30894-1304174241-0001-2--