From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: zsh workers <zsh-workers@zsh.org>
Subject: Re: SIGFPE crash
Date: Sun, 8 May 2011 18:33:42 +0100 [thread overview]
Message-ID: <20110508183342.1499439f@pws-pc.ntlworld.com> (raw)
In-Reply-To: <BANLkTikO3QSLA2h-6g9pz=gU_zi3iF6cQA@mail.gmail.com>
On Sun, 8 May 2011 00:27:30 +0200
Mikael Magnusson <mikachu@gmail.com> wrote:
> >> + if (a.u.l == LONG_MIN && b.u.l == -1)
> >
> > should be LLONG_MIN
> >
>
> It should probably be neither, zsh does some weird stuff to find a
> suitably long type for .l, which may or may not be a long long.
It needs a test in configure.ac where we check the type, around line
967, to check if LLONG_MIN and LLONG_MAX exist and if so define
ZSH_INT_MIN and ZSH_INT_MAX to those, and a bit later (after
the 64 bit stuff) if we didn't define them yet, test for LONG_MIN and
LONG_MAX and use those, otherwise (which shouldn't really happen) just
use some hackery with sizeof and shifts as a fallback (and perhaps print
a warning that we'd like to know about it).
--
Peter Stephenson <p.w.stephenson@ntlworld.com>
Web page now at http://homepage.ntlworld.com/p.w.stephenson/
next prev parent reply other threads:[~2011-05-08 18:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-07 21:56 Jon Mayo
2011-05-07 22:17 ` Mikael Magnusson
2011-05-07 22:19 ` Jon Mayo
2011-05-07 22:27 ` Mikael Magnusson
2011-05-07 23:48 ` Phil Pennock
2011-05-08 0:05 ` Jon Mayo
2011-05-08 0:10 ` Mikael Magnusson
2011-05-08 2:46 ` Bart Schaefer
2011-05-08 7:03 ` Jon Mayo
2011-05-08 17:33 ` Peter Stephenson [this message]
2011-05-09 10:21 ` Vincent Lefevre
2011-05-09 10:35 ` Vincent Lefevre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110508183342.1499439f@pws-pc.ntlworld.com \
--to=p.w.stephenson@ntlworld.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).