From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 185 invoked by alias); 8 May 2011 18:21:33 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 29190 Received: (qmail 14514 invoked from network); 8 May 2011 18:21:25 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received-SPF: pass (ns1.primenet.com.au: SPF record at ntlworld.com designates 81.103.221.56 as permitted sender) Date: Sun, 8 May 2011 18:33:42 +0100 From: Peter Stephenson To: zsh workers Subject: Re: SIGFPE crash Message-ID: <20110508183342.1499439f@pws-pc.ntlworld.com> In-Reply-To: References: X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Cloudmark-Analysis: v=1.1 cv=R50lirqlHffDPPkwUlkuVa99MrvKdVWo//yz83qex8g= c=1 sm=0 a=uObrxnre4hsA:10 a=kj9zAlcOel0A:10 a=pGLkceISAAAA:8 a=NLZqzBF-AAAA:8 a=fZaWB5xW8yk5r3AsBfoA:9 a=CjuIK1q_8ugA:10 a=MSl-tDqOz04A:10 a=_dQi-Dcv4p4A:10 a=HpAAvcLHHh0Zw7uRqdWCyQ==:117 On Sun, 8 May 2011 00:27:30 +0200 Mikael Magnusson wrote: > >> + if (a.u.l == LONG_MIN && b.u.l == -1) > > > > should be LLONG_MIN > > > > It should probably be neither, zsh does some weird stuff to find a > suitably long type for .l, which may or may not be a long long. It needs a test in configure.ac where we check the type, around line 967, to check if LLONG_MIN and LLONG_MAX exist and if so define ZSH_INT_MIN and ZSH_INT_MAX to those, and a bit later (after the 64 bit stuff) if we didn't define them yet, test for LONG_MIN and LONG_MAX and use those, otherwise (which shouldn't really happen) just use some hackery with sizeof and shifts as a fallback (and perhaps print a warning that we'd like to know about it). -- Peter Stephenson Web page now at http://homepage.ntlworld.com/p.w.stephenson/