From: Peter Stephenson <Peter.Stephenson@csr.com>
To: <zsh-workers@zsh.org>
Subject: Re: [PATCH] Compilation fix for AIX (missing consts)
Date: Mon, 9 May 2011 10:54:41 +0100 [thread overview]
Message-ID: <20110509105441.64be8f1c@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <20110506145142.4dba5b74@pwslap01u.europe.root.pri>
On Fri, 6 May 2011 14:51:42 +0100
Peter Stephenson <Peter.Stephenson@csr.com> wrote:
> So to
> fix it for AIX (an, indeed, to have any remote hope of keeping the
> AIX version in sync with the rest) we need to allow term.h to be
> included in the main shell.
>
> The issues I can see are with the names columns, lines, move, newline
> and tab (ick!). After fixing these, this now compiles and runs
> correctly on my machine. I can't entirely exclude the possibility it
> has subtly redefined some other word.
>
> Unfortunately, it means we're at the mercy of term.h everywhere it
> exists. Given that this only happens in the case we are trying to use
> it in at least one part of the shell, it's probably the right thing to
> do to use it everywhere. However, this could do with some major
> testing. I'll upload a new test version soon.
I've committed this. I'll upload a test version when a bit more dust
has settled elsewhere, but it could do with some testing. I suspect
there are some interesting versions of term.h around.
--
Peter Stephenson <pws@csr.com> Software Engineer
Tel: +44 (0)1223 692070 Cambridge Silicon Radio Limited
Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, UK
Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom
next prev parent reply other threads:[~2011-05-09 9:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-26 13:33 Jérémie Roquet
2011-04-26 19:16 ` Wayne Davison
2011-04-27 15:49 ` Jérémie Roquet
2011-04-27 18:54 ` Wayne Davison
2011-05-03 12:23 ` Jérémie Roquet
2011-05-06 13:51 ` Peter Stephenson
2011-05-06 14:16 ` Peter Stephenson
2011-05-09 9:54 ` Peter Stephenson [this message]
2011-05-09 10:33 ` Peter Stephenson
2011-05-03 10:23 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110509105441.64be8f1c@pwslap01u.europe.root.pri \
--to=peter.stephenson@csr.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).