From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28237 invoked by alias); 9 May 2011 09:55:49 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 29192 Received: (qmail 2284 invoked from network); 9 May 2011 09:55:37 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_HELO_PASS autolearn=ham version=3.3.1 Received-SPF: none (ns1.primenet.com.au: domain at csr.com does not designate permitted sender hosts) Date: Mon, 9 May 2011 10:54:41 +0100 From: Peter Stephenson To: Subject: Re: [PATCH] Compilation fix for AIX (missing consts) Message-ID: <20110509105441.64be8f1c@pwslap01u.europe.root.pri> In-Reply-To: <20110506145142.4dba5b74@pwslap01u.europe.root.pri> References: <20110506145142.4dba5b74@pwslap01u.europe.root.pri> Organization: Cambridge Silicon Radio X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.103.11.49] X-Scanned-By: MailControl A_10_80_00 (www.mailcontrol.com) on 10.68.0.115 On Fri, 6 May 2011 14:51:42 +0100 Peter Stephenson wrote: > So to > fix it for AIX (an, indeed, to have any remote hope of keeping the > AIX version in sync with the rest) we need to allow term.h to be > included in the main shell. > > The issues I can see are with the names columns, lines, move, newline > and tab (ick!). After fixing these, this now compiles and runs > correctly on my machine. I can't entirely exclude the possibility it > has subtly redefined some other word. > > Unfortunately, it means we're at the mercy of term.h everywhere it > exists. Given that this only happens in the case we are trying to use > it in at least one part of the shell, it's probably the right thing to > do to use it everywhere. However, this could do with some major > testing. I'll upload a new test version soon. I've committed this. I'll upload a test version when a bit more dust has settled elsewhere, but it could do with some testing. I suspect there are some interesting versions of term.h around. -- Peter Stephenson Software Engineer Tel: +44 (0)1223 692070 Cambridge Silicon Radio Limited Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, UK Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom