From: Peter Stephenson <Peter.Stephenson@csr.com>
To: <zsh-workers@zsh.org>
Subject: Re: patch to make $TERMINFO special
Date: Tue, 10 May 2011 16:42:09 +0100 [thread overview]
Message-ID: <20110510164209.1822aa24@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <20110509171620.GC3073@lorien.comfychair.org>
On Mon, 9 May 2011 10:16:21 -0700
Danek Duvall <duvall@la-z-boy.comfychair.org> wrote:
> On Mon, May 09, 2011 at 06:02:26PM +0100, Peter Stephenson wrote:
>
> > Hmmm... the code that sets the exported value (that terminfo uses)
> > is probably being set later, in which we do need to fix up
> > exports. I think it should be conditionalised, however...
>
> Okay. FWIW, I'm happy with the TERM=$TERM solution, too.
It's probably worth the effort to make TERMINFO special to avoid needing
people to rummage in the basement. As I said, TERMINFO is a specialised
enough name it's hard to see this causing a problem.
> > +/* Function used when we need to reinitialies the terminal */
>
> "reinitialise"
>
> > +/**/
> > +char *
> > +terminfogetfn(Param pm, char *x)
>
> The second parameter causes the compiler to emit a warning, and the
> first should probably be marked UNUSED().
I've fixed those and commited it.
--
Peter Stephenson <pws@csr.com> Software Engineer
Tel: +44 (0)1223 692070 Cambridge Silicon Radio Limited
Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, UK
Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom
prev parent reply other threads:[~2011-05-10 16:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-08 20:13 Danek Duvall
2011-05-09 11:16 ` Peter Stephenson
2011-05-09 15:51 ` Danek Duvall
2011-05-09 16:20 ` Peter Stephenson
2011-05-09 16:23 ` Danek Duvall
2011-05-09 17:02 ` Peter Stephenson
2011-05-09 17:16 ` Danek Duvall
2011-05-10 15:42 ` Peter Stephenson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110510164209.1822aa24@pwslap01u.europe.root.pri \
--to=peter.stephenson@csr.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).