From: Danek Duvall <duvall@la-z-boy.comfychair.org>
To: Peter Stephenson <Peter.Stephenson@csr.com>
Cc: "Zsh Hackers' List" <zsh-workers@zsh.org>
Subject: Re: zsh 4.3.11-dev-3
Date: Thu, 12 May 2011 13:13:43 -0700 [thread overview]
Message-ID: <20110512201343.GJ3073@lorien.comfychair.org> (raw)
In-Reply-To: <20110512182112.GI3073@lorien.comfychair.org>
[-- Attachment #1: Type: text/plain, Size: 442 bytes --]
Danek Duvall wrote:
> Builds fine on Solaris 11 and seems to be working okay so far, but there's
> a warning in Src/Modules/datetime.c that could be cleaned up:
> getcurrentsecs() is missing "UNUSED(Param pm)" in its parameters.
>
> The zftp module also has warnings because tcp_socket() and friends aren't
> declared. Should it be including tcp.mdh?
A patch for those and a couple of "statement not reached" warnings is attached.
Danek
[-- Attachment #2: warnings.patch --]
[-- Type: text/plain, Size: 2018 bytes --]
diff -durp zsh-4.3.11-dev-3.orig/Src/Builtins/rlimits.c zsh-4.3.11-dev-3/Src/Builtins/rlimits.c
--- zsh-4.3.11-dev-3.orig/Src/Builtins/rlimits.c 2010-01-05 08:29:35.000000000 -0800
+++ zsh-4.3.11-dev-3/Src/Builtins/rlimits.c 2011-05-12 13:01:00.146638714 -0700
@@ -954,7 +954,6 @@ int
cleanup_(Module m)
{
return setfeatureenables(m, &module_features, NULL);
- return 0;
}
/**/
diff -durp zsh-4.3.11-dev-3.orig/Src/Modules/datetime.c zsh-4.3.11-dev-3/Src/Modules/datetime.c
--- zsh-4.3.11-dev-3.orig/Src/Modules/datetime.c 2010-02-26 09:07:25.000000000 -0800
+++ zsh-4.3.11-dev-3/Src/Modules/datetime.c 2011-05-12 12:53:01.981573357 -0700
@@ -146,7 +146,7 @@ bin_strftime(char *nam, char **argv, Opt
}
static zlong
-getcurrentsecs()
+getcurrentsecs(UNUSED(Param pm))
{
return (zlong) time(NULL);
}
diff -durp zsh-4.3.11-dev-3.orig/Src/Modules/zftp.c zsh-4.3.11-dev-3/Src/Modules/zftp.c
--- zsh-4.3.11-dev-3.orig/Src/Modules/zftp.c 2009-12-16 10:39:06.000000000 -0800
+++ zsh-4.3.11-dev-3/Src/Modules/zftp.c 2011-05-12 12:52:50.729253065 -0700
@@ -50,6 +50,7 @@ struct zftp_session;
typedef struct zftp_session *Zftp_session;
#include "tcp.h"
+#include "tcp.mdh"
#include "zftp.mdh"
#include "zftp.pro"
diff -durp zsh-4.3.11-dev-3.orig/Src/Zle/computil.c zsh-4.3.11-dev-3/Src/Zle/computil.c
--- zsh-4.3.11-dev-3.orig/Src/Zle/computil.c 2011-05-06 06:28:34.000000000 -0700
+++ zsh-4.3.11-dev-3/Src/Zle/computil.c 2011-05-12 13:06:22.720489284 -0700
@@ -3358,7 +3358,6 @@ bin_compvalues(char *nam, char **args, U
return 0;
}
- return 1;
case 'D':
/* This returns the description and action to use if we are at
diff -durp zsh-4.3.11-dev-3.orig/Src/cond.c zsh-4.3.11-dev-3/Src/cond.c
--- zsh-4.3.11-dev-3.orig/Src/cond.c 2010-02-19 04:45:37.000000000 -0800
+++ zsh-4.3.11-dev-3/Src/cond.c 2011-05-12 13:06:29.514991273 -0700
@@ -403,7 +403,6 @@ evalcond(Estate state, char *fromtest)
zwarnnam(fromtest, "bad cond code");
return 2;
}
- return 1;
}
prev parent reply other threads:[~2011-05-12 20:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-12 15:28 Peter Stephenson
2011-05-12 15:29 ` Peter Stephenson
2011-05-12 16:17 ` Bart Schaefer
2011-05-12 18:21 ` Danek Duvall
2011-05-12 20:13 ` Danek Duvall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110512201343.GJ3073@lorien.comfychair.org \
--to=duvall@la-z-boy.comfychair.org \
--cc=Peter.Stephenson@csr.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).