zsh 4.3.11-dev-3

zsh 4.3.11-dev-3

[Peter Stephenson]

I've uploaded

ftp://ftp.zsh.org/pub/development/zsh-4.3.11-dev-2-doc.tar.bz2
ftp://ftp.zsh.org/pub/development/zsh-4.3.11-dev-2-doc.tar.gz
ftp://ftp.zsh.org/pub/development/zsh-4.3.11-dev-2.tar.bz2
ftp://ftp.zsh.org/pub/development/zsh-4.3.11-dev-2.tar.gz

This contains some quite significant reworking of the build system to
work around various problems, so it would be good to try it out on
anything other than very common systems.

-- 
Peter Stephenson <pws@csr.com>            Software Engineer
Tel: +44 (0)1223 692070                   Cambridge Silicon Radio Limited
Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, UK


Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom

Re: zsh 4.3.11-dev-3

[Peter Stephenson]

On Thu, 12 May 2011 16:28:35 +0100
Peter Stephenson <Peter.Stephenson@csr.com> wrote:
> I've uploaded
> 
> ftp://ftp.zsh.org/pub/development/zsh-4.3.11-dev-2-doc.tar.bz2
> ftp://ftp.zsh.org/pub/development/zsh-4.3.11-dev-2-doc.tar.gz
> ftp://ftp.zsh.org/pub/development/zsh-4.3.11-dev-2.tar.bz2
> ftp://ftp.zsh.org/pub/development/zsh-4.3.11-dev-2.tar.gz

It's dev-*3*, I noticed as soon as I hit "send".

-- 
Peter Stephenson <pws@csr.com>            Software Engineer
Tel: +44 (0)1223 692070                   Cambridge Silicon Radio Limited
Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, UK


Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom

Re: zsh 4.3.11-dev-3

[Bart Schaefer]

I haven't tried from the tarball but I can confirm that the current
CVS head builds on MacOS -- uname -a says:

Darwin macadamia 10.7.0 Darwin Kernel Version 10.7.0: Sat Jan 29 15:17:16 PST
2011; root:xnu-1504.9.37~1/RELEASE_I386 i386

and on CentOS 4, dynamic and static link, with build tree separate from
source tree:

Linux torch 2.6.9-89.ELsmp #1 SMP Mon Jun 22 12:32:43 EDT 2009 i686 i686 i386
GNU/Linux

On the latter with a static link I've started getting one harmless test
failure that I didn't get before:

Warning: zsh/example not linked: not checking autoloading
Test ../../zsh-4.0/Test/V01zmodload.ztst failed: bad status 1, expected 0 from:
  zmodload -u zsh/example
  builtin example
Error output:
(eval):zmodload:1: no such module zsh/example
(eval):2: no such builtin: example
Was testing: Autoloads are persistent

I think the "persistence" test should be skipped without an error when
the example module is not available.

Re: zsh 4.3.11-dev-3

[Danek Duvall]

On Thu, May 12, 2011 at 04:28:35PM +0100, Peter Stephenson wrote:

> I've uploaded
> 
> ftp://ftp.zsh.org/pub/development/zsh-4.3.11-dev-2-doc.tar.bz2
> ftp://ftp.zsh.org/pub/development/zsh-4.3.11-dev-2-doc.tar.gz
> ftp://ftp.zsh.org/pub/development/zsh-4.3.11-dev-2.tar.bz2
> ftp://ftp.zsh.org/pub/development/zsh-4.3.11-dev-2.tar.gz
> 
> This contains some quite significant reworking of the build system to
> work around various problems, so it would be good to try it out on
> anything other than very common systems.

Builds fine on Solaris 11 and seems to be working okay so far, but there's
a warning in Src/Modules/datetime.c that could be cleaned up:
getcurrentsecs() is missing "UNUSED(Param pm)" in its parameters.

The zftp module also has warnings because tcp_socket() and friends aren't
declared.  Should it be including tcp.mdh?

Danek

Re: zsh 4.3.11-dev-3

[Danek Duvall]

[-- Attachment #1: Type: text/plain, Size: 442 bytes --]

Danek Duvall wrote:

> Builds fine on Solaris 11 and seems to be working okay so far, but there's
> a warning in Src/Modules/datetime.c that could be cleaned up:
> getcurrentsecs() is missing "UNUSED(Param pm)" in its parameters.
> 
> The zftp module also has warnings because tcp_socket() and friends aren't
> declared.  Should it be including tcp.mdh?

A patch for those and a couple of "statement not reached" warnings is attached.

Danek

[-- Attachment #2: warnings.patch --]
[-- Type: text/plain, Size: 2018 bytes --]

diff -durp zsh-4.3.11-dev-3.orig/Src/Builtins/rlimits.c zsh-4.3.11-dev-3/Src/Builtins/rlimits.c
--- zsh-4.3.11-dev-3.orig/Src/Builtins/rlimits.c	2010-01-05 08:29:35.000000000 -0800
+++ zsh-4.3.11-dev-3/Src/Builtins/rlimits.c	2011-05-12 13:01:00.146638714 -0700
@@ -954,7 +954,6 @@ int
 cleanup_(Module m)
 {
     return setfeatureenables(m, &module_features, NULL);
-    return 0;
 }
 
 /**/
diff -durp zsh-4.3.11-dev-3.orig/Src/Modules/datetime.c zsh-4.3.11-dev-3/Src/Modules/datetime.c
--- zsh-4.3.11-dev-3.orig/Src/Modules/datetime.c	2010-02-26 09:07:25.000000000 -0800
+++ zsh-4.3.11-dev-3/Src/Modules/datetime.c	2011-05-12 12:53:01.981573357 -0700
@@ -146,7 +146,7 @@ bin_strftime(char *nam, char **argv, Opt
 }
 
 static zlong
-getcurrentsecs()
+getcurrentsecs(UNUSED(Param pm))
 {
     return (zlong) time(NULL);
 }
diff -durp zsh-4.3.11-dev-3.orig/Src/Modules/zftp.c zsh-4.3.11-dev-3/Src/Modules/zftp.c
--- zsh-4.3.11-dev-3.orig/Src/Modules/zftp.c	2009-12-16 10:39:06.000000000 -0800
+++ zsh-4.3.11-dev-3/Src/Modules/zftp.c	2011-05-12 12:52:50.729253065 -0700
@@ -50,6 +50,7 @@ struct zftp_session;
 typedef struct zftp_session *Zftp_session;
 
 #include "tcp.h"
+#include "tcp.mdh"
 #include "zftp.mdh"
 #include "zftp.pro"
 
diff -durp zsh-4.3.11-dev-3.orig/Src/Zle/computil.c zsh-4.3.11-dev-3/Src/Zle/computil.c
--- zsh-4.3.11-dev-3.orig/Src/Zle/computil.c	2011-05-06 06:28:34.000000000 -0700
+++ zsh-4.3.11-dev-3/Src/Zle/computil.c	2011-05-12 13:06:22.720489284 -0700
@@ -3358,7 +3358,6 @@ bin_compvalues(char *nam, char **args, U
 
 	    return 0;
 	}
-	return 1;
 
     case 'D':
         /* This returns the description and action to use if we are at
diff -durp zsh-4.3.11-dev-3.orig/Src/cond.c zsh-4.3.11-dev-3/Src/cond.c
--- zsh-4.3.11-dev-3.orig/Src/cond.c	2010-02-19 04:45:37.000000000 -0800
+++ zsh-4.3.11-dev-3/Src/cond.c	2011-05-12 13:06:29.514991273 -0700
@@ -403,7 +403,6 @@ evalcond(Estate state, char *fromtest)
 	zwarnnam(fromtest, "bad cond code");
 	return 2;
     }
-    return 1;
 }