From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18221 invoked by alias); 12 May 2011 20:13:57 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 29254 Received: (qmail 12574 invoked from network); 12 May 2011 20:13:56 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 Received-SPF: pass (ns1.primenet.com.au: SPF record at lorien.comfychair.org designates 173.8.144.98 as permitted sender) Date: Thu, 12 May 2011 13:13:43 -0700 From: Danek Duvall To: Peter Stephenson Cc: "Zsh Hackers' List" Subject: Re: zsh 4.3.11-dev-3 Message-ID: <20110512201343.GJ3073@lorien.comfychair.org> Mail-Followup-To: Danek Duvall , Peter Stephenson , Zsh Hackers' List References: <20110512162835.3f2c7b03@pwslap01u.europe.root.pri> <20110512182112.GI3073@lorien.comfychair.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="mxv5cy4qt+RJ9ypb" Content-Disposition: inline In-Reply-To: <20110512182112.GI3073@lorien.comfychair.org> User-Agent: Mutt/1.5.20 (2010-04-22) --mxv5cy4qt+RJ9ypb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Danek Duvall wrote: > Builds fine on Solaris 11 and seems to be working okay so far, but there's > a warning in Src/Modules/datetime.c that could be cleaned up: > getcurrentsecs() is missing "UNUSED(Param pm)" in its parameters. > > The zftp module also has warnings because tcp_socket() and friends aren't > declared. Should it be including tcp.mdh? A patch for those and a couple of "statement not reached" warnings is attached. Danek --mxv5cy4qt+RJ9ypb Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="warnings.patch" diff -durp zsh-4.3.11-dev-3.orig/Src/Builtins/rlimits.c zsh-4.3.11-dev-3/Src/Builtins/rlimits.c --- zsh-4.3.11-dev-3.orig/Src/Builtins/rlimits.c 2010-01-05 08:29:35.000000000 -0800 +++ zsh-4.3.11-dev-3/Src/Builtins/rlimits.c 2011-05-12 13:01:00.146638714 -0700 @@ -954,7 +954,6 @@ int cleanup_(Module m) { return setfeatureenables(m, &module_features, NULL); - return 0; } /**/ diff -durp zsh-4.3.11-dev-3.orig/Src/Modules/datetime.c zsh-4.3.11-dev-3/Src/Modules/datetime.c --- zsh-4.3.11-dev-3.orig/Src/Modules/datetime.c 2010-02-26 09:07:25.000000000 -0800 +++ zsh-4.3.11-dev-3/Src/Modules/datetime.c 2011-05-12 12:53:01.981573357 -0700 @@ -146,7 +146,7 @@ bin_strftime(char *nam, char **argv, Opt } static zlong -getcurrentsecs() +getcurrentsecs(UNUSED(Param pm)) { return (zlong) time(NULL); } diff -durp zsh-4.3.11-dev-3.orig/Src/Modules/zftp.c zsh-4.3.11-dev-3/Src/Modules/zftp.c --- zsh-4.3.11-dev-3.orig/Src/Modules/zftp.c 2009-12-16 10:39:06.000000000 -0800 +++ zsh-4.3.11-dev-3/Src/Modules/zftp.c 2011-05-12 12:52:50.729253065 -0700 @@ -50,6 +50,7 @@ struct zftp_session; typedef struct zftp_session *Zftp_session; #include "tcp.h" +#include "tcp.mdh" #include "zftp.mdh" #include "zftp.pro" diff -durp zsh-4.3.11-dev-3.orig/Src/Zle/computil.c zsh-4.3.11-dev-3/Src/Zle/computil.c --- zsh-4.3.11-dev-3.orig/Src/Zle/computil.c 2011-05-06 06:28:34.000000000 -0700 +++ zsh-4.3.11-dev-3/Src/Zle/computil.c 2011-05-12 13:06:22.720489284 -0700 @@ -3358,7 +3358,6 @@ bin_compvalues(char *nam, char **args, U return 0; } - return 1; case 'D': /* This returns the description and action to use if we are at diff -durp zsh-4.3.11-dev-3.orig/Src/cond.c zsh-4.3.11-dev-3/Src/cond.c --- zsh-4.3.11-dev-3.orig/Src/cond.c 2010-02-19 04:45:37.000000000 -0800 +++ zsh-4.3.11-dev-3/Src/cond.c 2011-05-12 13:06:29.514991273 -0700 @@ -403,7 +403,6 @@ evalcond(Estate state, char *fromtest) zwarnnam(fromtest, "bad cond code"); return 2; } - return 1; } --mxv5cy4qt+RJ9ypb--