From: Peter Stephenson <Peter.Stephenson@csr.com>
To: <zsh-workers@zsh.org>
Subject: Re: Zsh 4.3.12: subshell in midnight commander: precmd: 15: bad file descriptor
Date: Mon, 18 Jul 2011 16:24:35 +0100 [thread overview]
Message-ID: <20110718162435.4c6598e8@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <110718074551.ZM13628@torch.brasslantern.com>
On Mon, 18 Jul 2011 07:45:51 -0700
Bart Schaefer <schaefer@brasslantern.com> wrote:
> So it's the calling shell rather than the called shell that is closing
> a descriptor that it shouldn't.
I don't think so: both lsof and sh -c 'pwd >&11' agree that the FD is
still open in the lower shell.
See if this fixes it.
Index: Src/exec.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/exec.c,v
retrieving revision 1.198
diff -p -u -r1.198 exec.c
--- Src/exec.c 23 Jun 2011 19:29:24 -0000 1.198
+++ Src/exec.c 18 Jul 2011 15:20:29 -0000
@@ -3008,11 +3008,17 @@ execcmd(Estate state, int input, int out
if (!checkclobberparam(fn))
fil = -1;
else if (fn->fd2 > 9 &&
- (fn->fd2 > max_zsh_fd ||
- (fdtable[fn->fd2] != FDT_UNUSED &&
- fdtable[fn->fd2] != FDT_EXTERNAL) ||
- fn->fd2 == coprocin ||
- fn->fd2 == coprocout)) {
+ /*
+ * If the requested fd is > max_zsh_fd,
+ * the shell doesn't know about it.
+ * Just assume the user knows what they're
+ * doing.
+ */
+ (fn->fd2 <= max_zsh_fd &&
+ ((fdtable[fn->fd2] != FDT_UNUSED &&
+ fdtable[fn->fd2] != FDT_EXTERNAL) ||
+ fn->fd2 == coprocin ||
+ fn->fd2 == coprocout))) {
fil = -1;
errno = EBADF;
} else {
--
Peter Stephenson <pws@csr.com> Software Engineer
Tel: +44 (0)1223 692070 Cambridge Silicon Radio Limited
Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, UK
Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom
More information can be found at www.csr.com. Follow CSR on Twitter at http://twitter.com/CSR_PLC and read our blog at www.csr.com/blog
next prev parent reply other threads:[~2011-07-18 15:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-18 8:26 Pavel Reznicek
2011-07-18 9:07 ` Peter Stephenson
2011-07-18 10:04 ` Pavel Reznicek
2011-07-18 14:07 ` Bart Schaefer
2011-07-18 14:45 ` Bart Schaefer
2011-07-18 15:24 ` Peter Stephenson [this message]
2011-07-18 15:52 ` Bart Schaefer
2011-07-18 16:01 ` Peter Stephenson
2011-07-18 16:26 ` Bart Schaefer
2011-07-19 9:47 ` Peter Stephenson
2011-07-19 9:52 ` Peter Stephenson
2011-07-19 14:28 ` Bart Schaefer
2011-07-18 14:13 ` Peter Stephenson
2011-10-02 19:00 ` Pavel Reznicek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110718162435.4c6598e8@pwslap01u.europe.root.pri \
--to=peter.stephenson@csr.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).