From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29235 invoked by alias); 27 Jul 2011 10:18:40 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 29619 Received: (qmail 21989 invoked from network); 27 Jul 2011 10:18:37 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_HELO_PASS autolearn=ham version=3.3.1 Received-SPF: none (ns1.primenet.com.au: domain at csr.com does not designate permitted sender hosts) Date: Wed, 27 Jul 2011 10:48:18 +0100 From: Peter Stephenson To: Subject: Re: PATCH: fix some syntax depending on shortloops Message-ID: <20110727104818.175fc01f@pwslap01u.europe.root.pri> In-Reply-To: <1311757860-30180-1-git-send-email-mikachu@gmail.com> References: <1311757860-30180-1-git-send-email-mikachu@gmail.com> Organization: Cambridge Silicon Radio X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.103.11.26] X-Scanned-By: MailControl A-12-00-01 (www.mailcontrol.com) on 10.68.0.120 On Wed, 27 Jul 2011 11:11:00 +0200 Mikael Magnusson wrote: > Shortloops isn't in _comp_options so completions can't depend on it > being set. I discovered these two after updating my root .zshrc. I wonder if there's some mileage in that case in explicitly turning it off to level the playing field. I think the only effect would be user code that's not part of the normal system e.g. evals in zstyles would pick this up. Ideally this should be in a sandbox (but don't hold your breath). > I haven't tested _ethtool but it should be fine, it looks like it just > had broken syntax that happened to work with shortloops set. Yes, that just looked plain wrong. -- Peter Stephenson Software Engineer Tel: +44 (0)1223 692070 Cambridge Silicon Radio Limited Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, UK Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom More information can be found at www.csr.com. Follow CSR on Twitter at http://twitter.com/CSR_PLC and read our blog at www.csr.com/blog