zsh-workers
 help / color / mirror / code / Atom feed
* [PATCH] Escape colon at mplayer -ss option
@ 2011-08-25  4:42 eagletmt
  2011-08-30 15:23 ` Mikael Magnusson
  0 siblings, 1 reply; 3+ messages in thread
From: eagletmt @ 2011-08-25  4:42 UTC (permalink / raw)
  To: zsh-workers

---
 Completion/X/Command/_mplayer |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Completion/X/Command/_mplayer b/Completion/X/Command/_mplayer
index 665f44e..3cb10d0 100644
--- a/Completion/X/Command/_mplayer
+++ b/Completion/X/Command/_mplayer
@@ -77,7 +77,7 @@ _x_arguments -C -s \
   '-sid[turn on DVD subtitles]:language id' \
   '-speed[set playback speed rate]:playback speed rate' \
   '-srate[specify frequency of audio playback]:frequency (Hz)' \
-  '-ss[seek to given time position]:position (hh:mm\[\:ss\])' \
+  '-ss[seek to given time position]:position (hh\:mm\[\:ss\])' \
   '-sstep[specify time between displayed frames]:time (seconds)' \
   -ssf:mode -stop_xscreensaver \
   '-stereo:mode:((0\:stereo 1\:left\ channel 2\:right\ channel))' \
-- 
1.7.6


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Escape colon at mplayer -ss option
  2011-08-25  4:42 [PATCH] Escape colon at mplayer -ss option eagletmt
@ 2011-08-30 15:23 ` Mikael Magnusson
  2011-08-30 16:18   ` Simon Ruderich
  0 siblings, 1 reply; 3+ messages in thread
From: Mikael Magnusson @ 2011-08-30 15:23 UTC (permalink / raw)
  To: zsh-workers

On 25 August 2011 06:42, eagletmt <eagletmt@gmail.com> wrote:
> ---
>  Completion/X/Command/_mplayer |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Completion/X/Command/_mplayer b/Completion/X/Command/_mplayer
> index 665f44e..3cb10d0 100644
> --- a/Completion/X/Command/_mplayer
> +++ b/Completion/X/Command/_mplayer
> @@ -77,7 +77,7 @@ _x_arguments -C -s \
>   '-sid[turn on DVD subtitles]:language id' \
>   '-speed[set playback speed rate]:playback speed rate' \
>   '-srate[specify frequency of audio playback]:frequency (Hz)' \
> -  '-ss[seek to given time position]:position (hh:mm\[\:ss\])' \
> +  '-ss[seek to given time position]:position (hh\:mm\[\:ss\])' \
>   '-sstep[specify time between displayed frames]:time (seconds)' \
>   -ssf:mode -stop_xscreensaver \
>   '-stereo:mode:((0\:stereo 1\:left\ channel 2\:right\ channel))' \

rudi_s mentioned on irc that the [] shouldn't be escaped, then I
noticed they're in the wrong place too, so I'll commit this too,

-  '-ss[seek to given time position]:position (hh\:mm\[\:ss\])' \
+  '-ss[seek to given time position]:position ([[hh\:]mm\:]ss[.sss])' \

-- 
Mikael Magnusson


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Escape colon at mplayer -ss option
  2011-08-30 15:23 ` Mikael Magnusson
@ 2011-08-30 16:18   ` Simon Ruderich
  0 siblings, 0 replies; 3+ messages in thread
From: Simon Ruderich @ 2011-08-30 16:18 UTC (permalink / raw)
  To: zsh-workers

[-- Attachment #1: Type: text/plain, Size: 540 bytes --]

On Tue, Aug 30, 2011 at 05:23:21PM +0200, Mikael Magnusson wrote:
> rudi_s mentioned on irc that the [] shouldn't be escaped, then I
> noticed they're in the wrong place too, so I'll commit this too,
>
> -  '-ss[seek to given time position]:position (hh\:mm\[\:ss\])' \
> +  '-ss[seek to given time position]:position ([[hh\:]mm\:]ss[.sss])' \

Mikael generously allowed me to commit this patch so I could test
committing to CVS ;-)
-- 
+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-08-30 16:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-25  4:42 [PATCH] Escape colon at mplayer -ss option eagletmt
2011-08-30 15:23 ` Mikael Magnusson
2011-08-30 16:18   ` Simon Ruderich

Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).