From: Phil Pennock <zsh-workers+phil.pennock@spodhuis.org>
To: zsh-workers@zsh.org
Subject: Re: [patch] Re: UTF-8 and PCRE and metafy
Date: Mon, 24 Oct 2011 07:35:29 -0400 [thread overview]
Message-ID: <20111024113529.GA53002@redoubt.spodhuis.org> (raw)
In-Reply-To: <20111023173215.0be5ff0d@pws-pc.ntlworld.com>
On 2011-10-23 at 17:32 +0100, Peter Stephenson wrote:
> I didn't look through in great detail, so I haven't validated the
> structure, but certainly what I saw looked fine
Committed; 1.19 of pcre.c.
> You'd probably need to encapsulate it within a test for loading the
> library, given which it's probably easier just to copy D07multibyte.ztst
> and add to the prerequisites a test for loading zsh/pcre at that point,
> which ought to be easy.
I even tested the test before commit! *cough* Which shows that I still
have Y01completion.ztst hanging forever for me; need to figure that out.
Added "V07pcre.ztst", added a few tests.
At some point, there was a discussion about whether $MATCH/$match should
be _unset_ when regex tests fail: at present we don't. Did anyone have
any strong opinions on this? At the moment, I unset manually after each
print of results, for a batch of simple tests I added.
-Phil
next prev parent reply other threads:[~2011-10-24 11:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-08 6:52 Phil Pennock
2011-03-08 8:19 ` Bart Schaefer
2011-03-08 9:58 ` Peter Stephenson
2011-10-21 9:56 ` [patch] " Phil Pennock
2011-10-21 10:35 ` Phil Pennock
2011-10-23 16:32 ` [patch] " Peter Stephenson
2011-10-24 11:35 ` Phil Pennock [this message]
2011-10-24 11:43 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111024113529.GA53002@redoubt.spodhuis.org \
--to=zsh-workers+phil.pennock@spodhuis.org \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).