From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18453 invoked by alias); 25 Oct 2011 09:39:56 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 29856 Received: (qmail 27469 invoked from network); 25 Oct 2011 09:39:53 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_HELO_PASS autolearn=ham version=3.3.1 Received-SPF: none (ns1.primenet.com.au: domain at csr.com does not designate permitted sender hosts) Date: Tue, 25 Oct 2011 10:00:58 +0100 From: Peter Stephenson To: Subject: Re: [PATCH] better systemctl completion Message-ID: <20111025100058.4ce96dca@pwslap01u.europe.root.pri> In-Reply-To: <871uu2ut21.fsf@ft.bewatermyfriend.org> References: <20111024100147.1724c732@pwslap01u.europe.root.pri> <4EA549D1.2040009@gmail.com> <20111024122731.695d91fc@pwslap01u.europe.root.pri> <871uu2ut21.fsf@ft.bewatermyfriend.org> Organization: Cambridge Silicon Radio X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.101.11.233] X-Scanned-By: MailControl 7.6.3 (www.mailcontrol.com) on 10.68.0.163 On Mon, 24 Oct 2011 20:45:58 +0200 Frank Terbeck wrote: > Peter Stephenson wrote: > [...] > > Sorry, my mistake. I'll apply the patch. > [...] > > Um. The file got a new licence as GPLv3 ("# This file is released under > the GPLv3."). Certainly that's better avoided, it does complicate matters. We wouldn't be able to do that if it were part of the main shell without repercussions (we already have to be careful if the shell gets linked against GDBM). I don't think it has particular issues in the case of individual completion functions --- though if they became part of the library rather than the top level that would then affect the rest of the completion functions. Given that it's partly based on the bash systemctl completion you can argue it's inevitable in this case. Note the zsh licence already says "any provisions made in individual files take precedence" so it does provide for the general case (though this case is particularly complicated). -- Peter Stephenson Software Engineer Tel: +44 (0)1223 692070 Cambridge Silicon Radio Limited Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, UK Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom More information can be found at www.csr.com. Follow CSR on Twitter at http://twitter.com/CSR_PLC and read our blog at www.csr.com/blog