From: Peter Stephenson <Peter.Stephenson@csr.com>
To: <zsh-workers@zsh.org>
Subject: Re: pcre test failures
Date: Wed, 26 Oct 2011 13:48:53 +0100 [thread overview]
Message-ID: <20111026134853.48e1432e@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <a06001001cacd95106de1@kba.biglobe.ne.jp>
On Wed, 26 Oct 2011 19:49:17 +0900
Jun T. <takimoto-j@kba.biglobe.ne.jp> wrote:
> [2] If --enable-pcre is specified for ./configure
> but the pcre-config command is not installed on the host,
> then virtually empty pcre.so is built.
> I guess this is the second case in the Vin's post.
> pcre-config (and pcre.h etc.) are in pcre-dev (or similar) package in
> many Linux distros. Once I installed this package it worked fine
> (tested on Fedora14).
>
> I think it would be better to modify configure.ac so that enable-pcre
> is reset to "no" if pcre-config command is not found.
Yes, I've been trying to avoid problems like this. In general, it's
much better for a module not to be built than to load and announce it
can't do anything, which is no use to anyone.
Index: Src/Modules/pcre.mdd
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Modules/pcre.mdd,v
retrieving revision 1.4
diff -p -u -r1.4 pcre.mdd
--- Src/Modules/pcre.mdd 20 Jun 2007 20:59:18 -0000 1.4
+++ Src/Modules/pcre.mdd 26 Oct 2011 12:45:49 -0000
@@ -1,5 +1,5 @@
name=zsh/pcre
-link=`if test x$enable_pcre = xyes; then echo dynamic; else echo no; fi`
+link=`if test x$enable_pcre = xyes && (pcre-config --version >/dev/null 2>/dev/null); then echo dynamic; else echo no; fi`
load=no
autofeatures="b:pcre_compile b:pcre_study b:pcre_match"
--
Peter Stephenson <pws@csr.com> Software Engineer
Tel: +44 (0)1223 692070 Cambridge Silicon Radio Limited
Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, UK
Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom
More information can be found at www.csr.com. Follow CSR on Twitter at http://twitter.com/CSR_PLC and read our blog at www.csr.com/blog
next prev parent reply other threads:[~2011-10-26 12:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-26 1:58 Vin Shelton
2011-10-26 6:27 ` Phil Pennock
2011-10-26 10:49 ` Jun T.
2011-10-26 12:48 ` Peter Stephenson [this message]
2011-10-26 18:15 ` Vin Shelton
2011-10-26 18:30 ` Bart Schaefer
2011-10-26 23:32 ` Phil Pennock
2011-10-26 11:34 ` Vin Shelton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111026134853.48e1432e@pwslap01u.europe.root.pri \
--to=peter.stephenson@csr.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).