From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28023 invoked by alias); 26 Oct 2011 12:49:05 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 29865 Received: (qmail 7508 invoked from network); 26 Oct 2011 12:49:03 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_HELO_PASS autolearn=ham version=3.3.1 Received-SPF: none (ns1.primenet.com.au: domain at csr.com does not designate permitted sender hosts) Date: Wed, 26 Oct 2011 13:48:53 +0100 From: Peter Stephenson To: Subject: Re: pcre test failures Message-ID: <20111026134853.48e1432e@pwslap01u.europe.root.pri> In-Reply-To: References: <20111026062750.GA27151@redoubt.spodhuis.org> Organization: Cambridge Silicon Radio X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.101.11.233] X-Scanned-By: MailControl 7.6.3 (www.mailcontrol.com) on 10.71.0.124 On Wed, 26 Oct 2011 19:49:17 +0900 Jun T. wrote: > [2] If --enable-pcre is specified for ./configure > but the pcre-config command is not installed on the host, > then virtually empty pcre.so is built. > I guess this is the second case in the Vin's post. > pcre-config (and pcre.h etc.) are in pcre-dev (or similar) package in > many Linux distros. Once I installed this package it worked fine > (tested on Fedora14). > > I think it would be better to modify configure.ac so that enable-pcre > is reset to "no" if pcre-config command is not found. Yes, I've been trying to avoid problems like this. In general, it's much better for a module not to be built than to load and announce it can't do anything, which is no use to anyone. Index: Src/Modules/pcre.mdd =================================================================== RCS file: /cvsroot/zsh/zsh/Src/Modules/pcre.mdd,v retrieving revision 1.4 diff -p -u -r1.4 pcre.mdd --- Src/Modules/pcre.mdd 20 Jun 2007 20:59:18 -0000 1.4 +++ Src/Modules/pcre.mdd 26 Oct 2011 12:45:49 -0000 @@ -1,5 +1,5 @@ name=zsh/pcre -link=`if test x$enable_pcre = xyes; then echo dynamic; else echo no; fi` +link=`if test x$enable_pcre = xyes && (pcre-config --version >/dev/null 2>/dev/null); then echo dynamic; else echo no; fi` load=no autofeatures="b:pcre_compile b:pcre_study b:pcre_match" -- Peter Stephenson Software Engineer Tel: +44 (0)1223 692070 Cambridge Silicon Radio Limited Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, UK Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom More information can be found at www.csr.com. Follow CSR on Twitter at http://twitter.com/CSR_PLC and read our blog at www.csr.com/blog