zsh-workers
 help / color / mirror / code / Atom feed
From: Phil Pennock <zsh-workers+phil.pennock@spodhuis.org>
To: zsh-workers@zsh.org
Subject: Re: pcre test failures
Date: Wed, 26 Oct 2011 19:32:56 -0400	[thread overview]
Message-ID: <20111026233256.GA71559@redoubt.spodhuis.org> (raw)
In-Reply-To: <111026113001.ZM10650@torch.brasslantern.com>

On 2011-10-26 at 11:30 -0700, Bart Schaefer wrote:
> Or just this:

> -  zmodload zsh/pcre
> +  if ! zmodload zsh/pcre 2>/dev/null
> +  then
> +    ZTST_unimplemented="the zsh/pcre module is not available"
> +    return 0
> +  fi

That looks by far the best; applied, thanks.

Vin: sorry, I wasn't aware that there was a third state of "compiled but
empty" for the PCRE module, thought it was either not built or fully
featured.  (And yes, I did test the test before submitting it, though I
didn't test Bart's change, it's Obviously Right By Inspection (famous
last words)).

Peter: thanks for the cleanup in the .mdd file.

Okay, I believe, once more, that _now_ we have cleaned up all my mess
from PCRE/=~/UTF-8 changes.  Is there anything outstanding?

Is there anyone with a UTF8-aware system regexp library that can report
on that?  If such things exist, we likely need to metafy/unmetafy in the
regex module too (which is my fault).  If not, we can ignore it or fix
it anyway, knowing that there's no way to test that all the changes are
making it through -- I'd rather not fix until there's a platform to
_test_ changes on.

-Phil


  reply	other threads:[~2011-10-26 23:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-26  1:58 Vin Shelton
2011-10-26  6:27 ` Phil Pennock
2011-10-26 10:49   ` Jun T.
2011-10-26 12:48     ` Peter Stephenson
2011-10-26 18:15       ` Vin Shelton
2011-10-26 18:30     ` Bart Schaefer
2011-10-26 23:32       ` Phil Pennock [this message]
2011-10-26 11:34   ` Vin Shelton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111026233256.GA71559@redoubt.spodhuis.org \
    --to=zsh-workers+phil.pennock@spodhuis.org \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).