From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23687 invoked by alias); 26 Oct 2011 23:33:11 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 29868 Received: (qmail 16782 invoked from network); 26 Oct 2011 23:33:01 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received-SPF: none (ns1.primenet.com.au: domain at spodhuis.org does not designate permitted sender hosts) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=spodhuis.org; s=d201107; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:To:From:Date; bh=s8IOzDccuxQICSEwJ94zgoB1zhjJPeK64h9C6cdB4n0=; b=VHufLRY7cghexrG6AFqshCEaIDJveTCt01+RptjSvgOlgtfflkKisYWiD5yZwpRUorxNx1NHaHrriMVRGxFiuKs8R/D1Li8Jv6ZnQbAOCzDbRPWr7m7ifsdN3nw0LErkhwxz0DElRBzED0bhocUH9k6OX3R+zSJyH00RM85gvsg=; Date: Wed, 26 Oct 2011 19:32:56 -0400 From: Phil Pennock To: zsh-workers@zsh.org Subject: Re: pcre test failures Message-ID: <20111026233256.GA71559@redoubt.spodhuis.org> Mail-Followup-To: zsh-workers@zsh.org References: <20111026062750.GA27151@redoubt.spodhuis.org> <111026113001.ZM10650@torch.brasslantern.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <111026113001.ZM10650@torch.brasslantern.com> On 2011-10-26 at 11:30 -0700, Bart Schaefer wrote: > Or just this: > - zmodload zsh/pcre > + if ! zmodload zsh/pcre 2>/dev/null > + then > + ZTST_unimplemented="the zsh/pcre module is not available" > + return 0 > + fi That looks by far the best; applied, thanks. Vin: sorry, I wasn't aware that there was a third state of "compiled but empty" for the PCRE module, thought it was either not built or fully featured. (And yes, I did test the test before submitting it, though I didn't test Bart's change, it's Obviously Right By Inspection (famous last words)). Peter: thanks for the cleanup in the .mdd file. Okay, I believe, once more, that _now_ we have cleaned up all my mess from PCRE/=~/UTF-8 changes. Is there anything outstanding? Is there anyone with a UTF8-aware system regexp library that can report on that? If such things exist, we likely need to metafy/unmetafy in the regex module too (which is my fault). If not, we can ignore it or fix it anyway, knowing that there's no way to test that all the changes are making it through -- I'd rather not fix until there's a platform to _test_ changes on. -Phil