zsh-workers
 help / color / mirror / code / Atom feed
From: takimoto-j@kba.biglobe.ne.jp
To: zsh-workers@zsh.org
Subject: message from zmodload can be corrupted
Date: Thu, 27 Oct 2011 20:10:11 +0900 (JST)	[thread overview]
Message-ID: <20111027.201011.14682980.takimoto-j@kba.biglobe.ne.jp> (raw)

I noticed that on recent Fedora's (and maybe many other Linuxes)
the error message returned by dlerror() is "localized" and
can contain multibyte characters depending on the locale in use.
THen the message is unmetafied in nicezputs() and corrupted.
For example, in Japanese locale:

zsh$ echo $LANG
ja_JP.UTF-8
zsh$ zmodload zsh/foo
zsh: failed to load module `zsh/foo': /usr/local/lib/zsh/4.3.12-test-2/zsh/foo.so: \M-e$\M-1\M-f\)オ\M-c^ジェク\M-c^H\M-c^_ァイ\M-c\M-^K\M-c\M-^B<\M-i~=\M-c\M-^A`ま\M-c\M-^A\\M-c\M-^B>: \M-c\M-^Aの\M-c\M-^B(\M-c\M-^A^な\M-c^_ァイ\M-c\M-^K\M-c\M-^B#\M-c\nィ\M-c\M-^Lク\M-c^H\M-c\M-\nはあ\M-c\M-^B$ま\M-c\M-^A\\M-c\M-^B>

The following patch fixes this problem, but I don't know whether I'm on
the right track.

zsh-fixed$ zmodload zsh/foo
zsh: failed to load module `zsh/foo': /usr/local/lib/zsh/4.3.12-test-2/zsh/foo.so: 共有オブジェクトファイルを開けません: そのようなファイルやディレクトリはありません


Index: Src/module.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/module.c,v
retrieving revision 1.43
diff -u -r1.43 module.c
--- Src/module.c	10 Aug 2011 11:31:19 -0000	1.43
+++ Src/module.c	27 Oct 2011 09:57:53 -0000
@@ -1597,7 +1597,9 @@
     ret = try_load_module(name);
     if (!ret && !silent) {
 #ifdef HAVE_DLERROR
-	zwarn("failed to load module `%s': %s", name, dlerror());
+	char *metafied = metafy(dlerror(),-1,META_DUP);
+	zwarn("failed to load module `%s': %s", name, metafied);
+	free(metafied);
 #else
 	zwarn("failed to load module: %s", name);
 #endif




             reply	other threads:[~2011-10-27 22:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-27 11:10 takimoto-j [this message]
2011-10-28  9:57 ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111027.201011.14682980.takimoto-j@kba.biglobe.ne.jp \
    --to=takimoto-j@kba.biglobe.ne.jp \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).