File completion of scp (tentative fix)

["Ignacy Gawędzki" <zsh@qult.net>]

[-- Attachment #1: Type: text/plain, Size: 670 bytes --]

Hi,

It's been some time since I wanted to track this bug down and finally took the
time to do it.

Supposing you have a remote host with a file in the home directory that begins
with a dash, the completion may fail because the file argument is interpreted
by ls as an option.

See the attached patch, which adds a -- before the pattern, so that files
starting with a dash won't possibly be considered as options.  This is the way
to go with a GNU ls on the other side, but I don't know how other versions
will interpret that.  Maybe something more sophisticated has to be done to
remain as generic as possible.

-- 
Save the whales. Feed the hungry. Free the mallocs. 

[-- Attachment #2: zsh-scp-completion.patch --]
[-- Type: text/x-diff, Size: 657 bytes --]

diff --git a/Completion/Unix/Command/_ssh b/Completion/Unix/Command/_ssh
index d0944c6..0ec9c84 100644
--- a/Completion/Unix/Command/_ssh
+++ b/Completion/Unix/Command/_ssh
@@ -16,7 +16,7 @@ _remote_files () {
     then rempat="${PREFIX%%[^./][^/]#}\*"
     else rempat="${(q)PREFIX%%[^./][^/]#}\*"
     fi
-    remfiles=(${(M)${(f)"$(_call_program files ssh -o BatchMode=yes $args -a -x ${IPREFIX%:} ls -d1FL "$rempat" 2>/dev/null)"}%%[^/]#(|/)})
+    remfiles=(${(M)${(f)"$(_call_program files ssh -o BatchMode=yes $args -a -x ${IPREFIX%:} ls -d1FL -- "$rempat" 2>/dev/null)"}%%[^/]#(|/)})
     compset -P '*/'
     compset -S '/*' || suf='remote file'