From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3398 invoked by alias); 2 Dec 2011 17:24:05 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 29928 Received: (qmail 25002 invoked from network); 2 Dec 2011 17:24:03 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_HELO_PASS autolearn=ham version=3.3.2 Received-SPF: none (ns1.primenet.com.au: domain at csr.com does not designate permitted sender hosts) Date: Fri, 2 Dec 2011 17:23:53 +0000 From: Peter Stephenson To: Zsh workers Subject: Re: PATCH: test output pattern matching Message-ID: <20111202172353.5edfcf04@pwslap01u.europe.root.pri> In-Reply-To: <20111202170356.GA6110@coredump.raveland.priv> References: <15488.1322689558@pws-pc.ntlworld.com> <14298.1322742430@thecus.kiddle.eu> <20111201125247.0abdc564@pwslap01u.europe.root.pri> <20111201212742.365c9e13@pws-pc.ntlworld.com> <20111202170356.GA6110@coredump.raveland.priv> Organization: Cambridge Silicon Radio X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.101.11.233] X-Scanned-By: MailControl 7.6.4 (www.mailcontrol.com) on 10.68.0.158 On Fri, 2 Dec 2011 18:03:56 +0100 wrote: > ./A04redirect.ztst: starting. > *** /usr/ports/pobj/zsh-4.3.13/zsh-4.3.13/tmp.ztst.err.6420 Fri Dec 2 17:58:33 2011 > --- /usr/ports/pobj/zsh-4.3.13/zsh-4.3.13/tmp.ztst.terr.6420 Fri Dec 2 17:58:33 2011 > *************** > *** 1 **** > - (eval):1: failed to close file descriptor 3: bad file descriptor > --- 0 ---- That might mean file descriptor 3 is open, so closing it didn't fail. What we could do is ensure it's closed, ignoring the status and error output, then try to close it again. Index: Test/A04redirect.ztst =================================================================== RCS file: /cvsroot/zsh/zsh/Test/A04redirect.ztst,v retrieving revision 1.22 diff -p -u -r1.22 A04redirect.ztst --- Test/A04redirect.ztst 1 Dec 2011 21:52:55 -0000 1.22 +++ Test/A04redirect.ztst 2 Dec 2011 17:22:56 -0000 @@ -152,10 +152,11 @@ >hello >goodbye - (exec 3<&- + ({ exec 3<&- } 2>/dev/null + exec 3<&- read foo <&-) 1:'<&-' redirection -*?\(eval\):1: failed to close file descriptor 3:* +*?\(eval\):*: failed to close file descriptor 3:* print foo >&- 0:'>&-' redirection -- Peter Stephenson Software Engineer Tel: +44 (0)1223 692070 Cambridge Silicon Radio Limited Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, UK Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom More information can be found at www.csr.com. Follow CSR on Twitter at http://twitter.com/CSR_PLC and read our blog at www.csr.com/blog