zsh-workers
 help / color / mirror / code / Atom feed
From: ports@raveland.org
To: Peter Stephenson <Peter.Stephenson@csr.com>
Cc: Zsh workers <zsh-workers@zsh.org>
Subject: Re: PATCH: test output pattern matching
Date: Sat, 3 Dec 2011 20:17:10 +0100	[thread overview]
Message-ID: <20111203191709.GA1294@coredump.raveland.priv> (raw)
In-Reply-To: <20111202172353.5edfcf04@pwslap01u.europe.root.pri>

On Fri, Dec 02, 2011 at 05:23:53PM +0000, Peter Stephenson wrote:
> On Fri, 2 Dec 2011 18:03:56 +0100
> <ports@raveland.org> wrote:
> > ./A04redirect.ztst: starting.
> > *** /usr/ports/pobj/zsh-4.3.13/zsh-4.3.13/tmp.ztst.err.6420     Fri Dec  2 17:58:33 2011
> > --- /usr/ports/pobj/zsh-4.3.13/zsh-4.3.13/tmp.ztst.terr.6420    Fri Dec  2 17:58:33 2011
> > ***************
> > *** 1 ****
> > - (eval):1: failed to close file descriptor 3: bad file descriptor
> > --- 0 ----
> 
> That might mean file descriptor 3 is open, so closing it didn't
> fail.  What we could do is ensure it's closed, ignoring the status and
> error output, then try to close it again.
> 
> Index: Test/A04redirect.ztst
> ===================================================================
> RCS file: /cvsroot/zsh/zsh/Test/A04redirect.ztst,v
> retrieving revision 1.22
> diff -p -u -r1.22 A04redirect.ztst
> --- Test/A04redirect.ztst	1 Dec 2011 21:52:55 -0000	1.22
> +++ Test/A04redirect.ztst	2 Dec 2011 17:22:56 -0000
> @@ -152,10 +152,11 @@
>  >hello
>  >goodbye
>  
> -  (exec 3<&-
> +  ({ exec 3<&- } 2>/dev/null
> +  exec 3<&-
>    read foo <&-)
>  1:'<&-' redirection
> -*?\(eval\):1: failed to close file descriptor 3:*
> +*?\(eval\):*: failed to close file descriptor 3:*
>  
>    print foo >&-
>  0:'>&-' redirection
> 

Thanks. With this diff, i no longer have the error.
Regards,


  reply	other threads:[~2011-12-03 19:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <15488.1322689558@pws-pc.ntlworld.com>
2011-12-01 12:27 ` zsh 4.3.13 released Oliver Kiddle
2011-12-01 12:52   ` Peter Stephenson
2011-12-01 21:27     ` PATCH: test output pattern matching Peter Stephenson
2011-12-02 17:03       ` ports
2011-12-02 17:23         ` Peter Stephenson
2011-12-03 19:17           ` ports [this message]
2011-12-01 23:48     ` zsh 4.3.13 released Baptiste Daroussin
2011-12-02 13:34       ` Peter Stephenson
2011-12-02 23:06         ` Baptiste Daroussin
     [not found] ` <20111203191925.GB1294@coredump.raveland.priv>
2011-12-03 19:44   ` Peter Stephenson
2011-12-03 22:19     ` ports
2011-12-03 22:56       ` Peter Stephenson
2011-12-04 12:42         ` ports

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111203191709.GA1294@coredump.raveland.priv \
    --to=ports@raveland.org \
    --cc=Peter.Stephenson@csr.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).