From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19849 invoked by alias); 9 Dec 2011 14:01:17 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 29959 Received: (qmail 18163 invoked from network); 9 Dec 2011 14:01:04 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_HELO_PASS autolearn=ham version=3.3.2 Received-SPF: none (ns1.primenet.com.au: domain at csr.com does not designate permitted sender hosts) Date: Fri, 9 Dec 2011 13:59:52 +0000 From: Peter Stephenson To: Subject: Re: PATCH: Completion: Add new _remote_files() helper and use it to reduce code duplication. Message-ID: <20111209135952.7cb7c934@pwslap01u.europe.root.pri> In-Reply-To: <7e26d3ea1b2ebe2924bc4c05adfca80e1e9e2e83.1322257147.git.simon@ruderich.org> References: <7e26d3ea1b2ebe2924bc4c05adfca80e1e9e2e83.1322257147.git.simon@ruderich.org> Organization: Cambridge Silicon Radio X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.101.11.233] X-Scanned-By: MailControl 7.6.5 (www.mailcontrol.com) on 10.71.0.127 On Fri, 25 Nov 2011 23:00:17 +0100 Simon Ruderich wrote: > This patch adds a new completion utility _remote_files() which > tries to reduce some code duplication when completing remote > files. > > Please report any mistakes or overcomplicated solutions (patches > are welcome). > > I've tested it (except for _rlogin as I don't use rsh) but I'm > sure there are some cases I missed. Please have a look and test > it. I suggest you commit these now the release is out of the way --- I've tried it out a little but I don't use remote file access (other than transparent) all that much. -- Peter Stephenson Software Engineer Tel: +44 (0)1223 692070 Cambridge Silicon Radio Limited Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, UK Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom More information can be found at www.csr.com. Follow CSR on Twitter at http://twitter.com/CSR_PLC and read our blog at www.csr.com/blog