From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: zsh-workers@zsh.org
Subject: Re: Bug in sh emulation
Date: Sun, 11 Dec 2011 19:39:49 +0000 [thread overview]
Message-ID: <20111211193949.2d58062b@pws-pc.ntlworld.com> (raw)
In-Reply-To: <20111210232801.7dc8fef2@pws-pc.ntlworld.com>
Not so much a follow up as a separate point...
If we're letting the subshell do job control (not resetting MONITOR in
entersubsh() because POSIXJOBS is set), then presumably we shouldn't be
resetting the signals that are special to shells that do job control?
This actually makes the issue go away, but I'm not sure at all sure it's
the basic issue; it's part of the stuff I'm hoping Mystified of Marin
County might know a little more about.
Having said that, the shell does make strenuous efforts to ignore these
signals when doing job control, so I'm reasonable sure this is the right
thing to do here.
Index: Src/exec.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/exec.c,v
retrieving revision 1.205
diff -p -u -r1.205 exec.c
--- Src/exec.c 26 Oct 2011 18:48:13 -0000 1.205
+++ Src/exec.c 11 Dec 2011 19:32:17 -0000
@@ -959,7 +959,7 @@ entersubsh(int flags)
if ((flags & ESUB_REVERTPGRP) && getpid() == mypgrp)
release_pgrp();
shout = NULL;
- if (isset(MONITOR)) {
+ if (isset(MONITOR) && !isset(POSIXJOBS)) {
signal_default(SIGTTOU);
signal_default(SIGTTIN);
signal_default(SIGTSTP);
--
Peter Stephenson <p.w.stephenson@ntlworld.com>
Web page now at http://homepage.ntlworld.com/p.w.stephenson/
next prev parent reply other threads:[~2011-12-11 19:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-10 1:39 Ivan S. Freitas
2011-12-10 2:47 ` Bart Schaefer
2011-12-10 3:40 ` Bart Schaefer
2011-12-10 18:15 ` Peter Stephenson
2011-12-10 19:40 ` Peter Stephenson
2011-12-10 23:28 ` Peter Stephenson
2011-12-11 19:39 ` Peter Stephenson [this message]
2011-12-11 20:20 ` Peter Stephenson
2011-12-11 20:56 ` Peter Stephenson
2011-12-11 23:39 ` Bart Schaefer
2011-12-12 10:01 ` Peter Stephenson
2011-12-12 10:14 ` Peter Stephenson
2011-12-12 15:44 ` Bart Schaefer
2011-12-12 16:06 ` Peter Stephenson
2011-12-12 18:10 ` Bart Schaefer
2011-12-12 19:16 ` Peter Stephenson
2011-12-11 22:37 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111211193949.2d58062b@pws-pc.ntlworld.com \
--to=p.w.stephenson@ntlworld.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).