PATCH: _update_alternatives: add missing options in completion

PATCH: _update_alternatives: add missing options in completion

[Ole Jørgen Brønner]

(Against 1c2ff6852911c47b1386d72e781b465f140e77eb)

Even though the version in Debian stable doesn't list all these in the --help message they are supported. (see man page)

Hopefully I didn't make any mistakes. First time I've messed with completion code.

---
diff --git a/Completion/Debian/Command/_update-alternatives b/Completion/Debian/Command/_update-al
index dd1d4fc..47cda1a 100644
--- a/Completion/Debian/Command/_update-alternatives
+++ b/Completion/Debian/Command/_update-alternatives
@@ -16,11 +16,21 @@ _arguments -C \
    '--version' \
    '--altdir:altdir:_files -/' \
    '--admindir:admindir:_files -/' \
+  '--log:log file:_files -/' \
+  '--force' \
+  '--skip-auto' \
    '--install:*::alt:= ->install' \
    '--remove:*::alt:= ->remove' \
+  '--remove-all:name:_files -W $alterdir' \
    '--auto:name:_files -W $alterdir' \
    '--display:name:_files -W $alterdir' \
-  '--config:name:_files -W $alterdir' && return
+  '--query:name:_files -W $alterdir' \
+  '--list:name:_files -W $alterdir' \
+  '--get-selections' \
+  '--set-selections' \
+  '--config:name:_files -W $alterdir' \
+  '--set:name:_files -W $alterdir:path:_files -/' \
+  '--all' && return

  while true; do
    case "$state" in

--

Ole Jørgen Brønner

Re: PATCH: _update_alternatives: add missing options in completion

[Mikael Magnusson]

2011/9/18 Ole Jørgen Brønner <olejorgenb@yahoo.no>:
> (Against 1c2ff6852911c47b1386d72e781b465f140e77eb)
>
> Even though the version in Debian stable doesn't list all these in the
> --help message they are supported. (see man page)
>
> Hopefully I didn't make any mistakes. First time I've messed with completion
> code.

Any reason nobody else committed this?

> ---
> diff --git a/Completion/Debian/Command/_update-alternatives
> b/Completion/Debian/Command/_update-al
> index dd1d4fc..47cda1a 100644
> --- a/Completion/Debian/Command/_update-alternatives
> +++ b/Completion/Debian/Command/_update-alternatives
> @@ -16,11 +16,21 @@ _arguments -C \
>   '--version' \
>   '--altdir:altdir:_files -/' \
>   '--admindir:admindir:_files -/' \
> +  '--log:log file:_files -/' \
> +  '--force' \
> +  '--skip-auto' \
>   '--install:*::alt:= ->install' \
>   '--remove:*::alt:= ->remove' \
> +  '--remove-all:name:_files -W $alterdir' \
>   '--auto:name:_files -W $alterdir' \
>   '--display:name:_files -W $alterdir' \
> -  '--config:name:_files -W $alterdir' && return
> +  '--query:name:_files -W $alterdir' \
> +  '--list:name:_files -W $alterdir' \
> +  '--get-selections' \
> +  '--set-selections' \
> +  '--config:name:_files -W $alterdir' \
> +  '--set:name:_files -W $alterdir:path:_files -/' \
> +  '--all' && return
>
>  while true; do
>   case "$state" in
>
> --
>
> Ole Jørgen Brønner



-- 
Mikael Magnusson

Re: PATCH: _update_alternatives: add missing options in completion

[Bart Schaefer]

On Dec 14,  2:13am, Mikael Magnusson wrote:
}
} Any reason nobody else committed this?

Not a reason related to the content of the patch, anyway ...

Re: PATCH: _update_alternatives: add missing options in completion

[Mikael Magnusson]

On 14 December 2011 05:55, Bart Schaefer <schaefer@brasslantern.com> wrote:
> On Dec 14,  2:13am, Mikael Magnusson wrote:
> }
> } Any reason nobody else committed this?
>
> Not a reason related to the content of the patch, anyway ...

In that case I guess I'll commit it. Nobody really explained our
system to me yet ;).

-- 
Mikael Magnusson

Re: PATCH: _update_alternatives: add missing options in completion

[Peter Stephenson]

On Wed, 14 Dec 2011 13:47:49 +0100
Mikael Magnusson <mikachu@gmail.com> wrote:
> On 14 December 2011 05:55, Bart Schaefer <schaefer@brasslantern.com> wrote:
> > On Dec 14,  2:13am, Mikael Magnusson wrote:
> > }
> > } Any reason nobody else committed this?
> >
> > Not a reason related to the content of the patch, anyway ...
> 
> In that case I guess I'll commit it. Nobody really explained our
> system to me yet ;).

Debian stuff has tended to be handled by Clint, but if you're able to
try it out, feel free to commit it...  generally with completion
functions submitted by users, whoever happens to use the tool in
question is a good person to commit it.

-- 
Peter Stephenson <pws@csr.com>            Software Engineer
Tel: +44 (0)1223 692070                   Cambridge Silicon Radio Limited
Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, UK


Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom
More information can be found at www.csr.com. Follow CSR on Twitter at http://twitter.com/CSR_PLC and read our blog at www.csr.com/blog