From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21806 invoked by alias); 4 Jan 2012 17:30:28 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 30083 Received: (qmail 15391 invoked from network); 4 Jan 2012 17:30:25 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 Received-SPF: neutral (ns1.primenet.com.au: 74.125.82.43 is neither permitted nor denied by SPF record at ntlworld.com) X-ProxyUser-IP: 86.6.29.42 Date: Wed, 4 Jan 2012 17:30:17 +0000 From: Peter Stephenson To: zsh-workers@zsh.org Cc: 654225@bugs.debian.org Subject: Re: PATCH: Restore `LC_ALL' when setting `LANG' Message-ID: <20120104173017.3b10a803@pws-pc.ntlworld.com> In-Reply-To: <20120104021641.GD4513@xvii.vinc17.org> References: <20120102132718.GA12143@gatsby.mbjnet.dk> <87fwfyb2if.fsf@ft.bewatermyfriend.org> <20120102154714.GA20663@gatsby.mbjnet.dk> <87wr9a9ely.fsf@ft.bewatermyfriend.org> <20120103111049.GA5673@gatsby.mbjnet.dk> <87sjjw98yl.fsf@ft.bewatermyfriend.org> <87k458974e.fsf@ft.bewatermyfriend.org> <2012-01-03T15-59-18@devnull.michael-prokop.at> <87boqk95we.fsf@ft.bewatermyfriend.org> <87y5to7qob.fsf@ft.bewatermyfriend.org> <20120104021641.GD4513@xvii.vinc17.org> X-Mailer: Claws Mail 3.7.9 (GTK+ 2.24.7; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On 2012-01-03 16:26:44 +0100, Frank Terbeck wrote: > I think the patch below fixes the issue correctly, by restoring LC_ALL > from its parameter along the way with all the other LC_* values zsh > cares about. Looks plausible, without following through all the implications. On Wed, 4 Jan 2012 03:16:41 +0100 Vincent Lefevre wrote: > I don't understand why zsh has anything to do with environment > variables to detect the charset (if I understood correctly). > Why not using nl_langinfo(CODESET)? Intercepting the setting of environment variables is mostly to ensure setlocale() gets run when necessary. -- Peter Stephenson Web page now at http://homepage.ntlworld.com/p.w.stephenson/