From: Peter Stephenson <Peter.Stephenson@csr.com>
To: <zsh-workers@zsh.org>
Subject: Re: PATCH: Fix segfaults with exec options
Date: Mon, 16 Jan 2012 14:49:29 +0000 [thread overview]
Message-ID: <20120116144929.787e6366@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <87ty3v92gw.fsf@ft.bewatermyfriend.org>
On Mon, 16 Jan 2012 14:55:11 +0100
Frank Terbeck <ft@bewatermyfriend.org> wrote:
> Maybe he (or someone else) has an idea about how to fix this at a more
> fundamental level. To me, my fix just plugs some holes with duct tape.
Looks OK to me. There isn't a more fundamental level --- it needs an
argument and you're intercepting the point where it finds out it doesn't
have one.
This is different from most "real" builtins, which have a handler that
parses options and counts arguments. As exec is special that's done at
this point; there's no higher level parsing involved.
--
Peter Stephenson <pws@csr.com> Software Engineer
Tel: +44 (0)1223 692070 Cambridge Silicon Radio Limited
Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, UK
Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom
More information can be found at www.csr.com. Follow CSR on Twitter at http://twitter.com/CSR_PLC and read our blog at www.csr.com/blog
next prev parent reply other threads:[~2012-01-16 15:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-16 13:55 Frank Terbeck
2012-01-16 14:49 ` Peter Stephenson [this message]
2012-01-17 3:31 ` Phil Pennock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120116144929.787e6366@pwslap01u.europe.root.pri \
--to=peter.stephenson@csr.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).