From: Phil Pennock <zsh-workers+phil.pennock@spodhuis.org>
To: Frank Terbeck <ft@bewatermyfriend.org>
Cc: zsh-workers@zsh.org
Subject: Re: PATCH: Fix segfaults with exec options
Date: Mon, 16 Jan 2012 22:31:42 -0500 [thread overview]
Message-ID: <20120117033142.GA85725@redoubt.spodhuis.org> (raw)
In-Reply-To: <87ty3v92gw.fsf@ft.bewatermyfriend.org>
On 2012-01-16 at 14:55 +0100, Frank Terbeck wrote:
> I've CC:ed Phil, who appears to be the original author of the code
> because I don't know the code very well and `execcmd()', being the 1000+
> lines function it is, intimidates me a little...
Erk. Sorry. :( *blush* Stupid mistake on my part.
> Maybe he (or someone else) has an idea about how to fix this at a more
> fundamental level. To me, my fix just plugs some holes with duct tape.
The "options for keywords" stuff is all a bit of a hack, since
fundamentally they're not supposed to take options, but bash does and
various tools assume you can ssh with certain command-line constructs,
so these were put in for interoperability.
Sorry for the lack of corner case analysis on my part.
--
https://twitter.com/syscomet
prev parent reply other threads:[~2012-01-17 3:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-16 13:55 Frank Terbeck
2012-01-16 14:49 ` Peter Stephenson
2012-01-17 3:31 ` Phil Pennock [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120117033142.GA85725@redoubt.spodhuis.org \
--to=zsh-workers+phil.pennock@spodhuis.org \
--cc=ft@bewatermyfriend.org \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).