From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19420 invoked by alias); 17 Jan 2012 03:47:40 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 30113 Received: (qmail 8614 invoked from network); 17 Jan 2012 03:47:38 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIM_ADSP_ALL, DKIM_SIGNED,RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.2 Received-SPF: none (ns1.primenet.com.au: domain at spodhuis.org does not designate permitted sender hosts) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=spodhuis.org; s=d201107; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=VToRkOx1ixrRyPz6mZ/ur+Ev34k3tuSigp9VfWSVMjQ=; b=iBoycf5mcoNy8NzYftLD2xRw7eelIr6TxJxWtwc+7/G3PZpLLT1O/DUS/lVbK6ifpFmdpM5pBlKuA21ATznJEootO0ohsRFForsxxkia2Z7B+fzUEhaBC2qygQtyxBkywwfbXR0I0BSeDaCcspQpKiZbwYx8+vYrKgMMfq9yEuE=; Date: Mon, 16 Jan 2012 22:31:42 -0500 From: Phil Pennock To: Frank Terbeck Cc: zsh-workers@zsh.org Subject: Re: PATCH: Fix segfaults with exec options Message-ID: <20120117033142.GA85725@redoubt.spodhuis.org> Mail-Followup-To: Frank Terbeck , zsh-workers@zsh.org References: <87ty3v92gw.fsf@ft.bewatermyfriend.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87ty3v92gw.fsf@ft.bewatermyfriend.org> On 2012-01-16 at 14:55 +0100, Frank Terbeck wrote: > I've CC:ed Phil, who appears to be the original author of the code > because I don't know the code very well and `execcmd()', being the 1000+ > lines function it is, intimidates me a little... Erk. Sorry. :( *blush* Stupid mistake on my part. > Maybe he (or someone else) has an idea about how to fix this at a more > fundamental level. To me, my fix just plugs some holes with duct tape. The "options for keywords" stuff is all a bit of a hack, since fundamentally they're not supposed to take options, but bash does and various tools assume you can ssh with certain command-line constructs, so these were put in for interoperability. Sorry for the lack of corner case analysis on my part. -- https://twitter.com/syscomet