zsh-workers
 help / color / mirror / code / Atom feed
From: Vincent Lefevre <vincent@vinc17.net>
To: zsh-workers@zsh.org
Subject: Re: suspend (^Z) behavior while a function is running is unclear
Date: Mon, 20 Feb 2012 17:09:45 +0100	[thread overview]
Message-ID: <20120220160944.GC7797@xvii.vinc17.org> (raw)
In-Reply-To: <20120220151309.4cc1a83d@pwslap01u.europe.root.pri>

On 2012-02-20 15:13:09 +0000, Peter Stephenson wrote:
> On Mon, 20 Feb 2012 14:02:59 +0100
> Vincent Lefevre <vincent@vinc17.net> wrote:
> > BTW, concerning zsh, if the behavior is regarded as correct, a fork
> > is still done even when the suspended command is the last one in the
> > function, e.g.
> > 
> >   foo() { emacs "$@"; }
> 
> There's certainly no good reason for trying to make a special case
> here; it's complicated for very little gain.
> 
> > Is the fork really necessary?
> 
> If you're actually trying to do real, live job control (rather than some
> internal approximation to it), yes, as that operates on processes, and
> (in your example) the shell function is the top-level code you need to
> suspend, regardless of any processes that may also have been started
> from it. I can't tell you if it's necessary for what you thought you
> were trying to do, if it wasn't job control.

Well, I have an emacs wrapper that does various things, then runs
emacs. Thus, when I suspend it or run it in background, there's a
spurious zsh process, which is sometimes a bit confusing. But to
avoid that, perhaps it's better to have a real script, not a zsh
function.

> Index: Doc/Zsh/jobs.yo
> ===================================================================
> RCS file: /cvsroot/zsh/zsh/Doc/Zsh/jobs.yo,v
> retrieving revision 1.5
> diff -p -u -r1.5 jobs.yo
> --- Doc/Zsh/jobs.yo	29 Mar 2006 19:25:15 -0000	1.5
> +++ Doc/Zsh/jobs.yo	20 Feb 2012 15:00:32 -0000
> @@ -37,6 +37,21 @@ when it is typed.
>  
>  A job being run in the background will suspend if it tries to read
>  from the terminal.
> +
> +Note that if the job running in the foreground is a shell function,
> +then suspending it will have the effect of causing the shell to fork.
> +This is necessary to separate the function's state from that of the
> +parent shell performing the job control, so that the latter can return
> +to the command line prompt.  As a result, even if tt(fg) is
> +used to continue the job the function will no longer be part of the
> +parent shell, and any variables set by the function will not be visible
> +in the parent shell.  Thus the behaviour is different from the case
> +where the function was never suspended.  Zsh is is different from many
                                                ^^^^^
duplicate "is"

> +other shells in this regard.
> +
> +The same behaviour is found when the shell is executing code as the
> +right hand side of a pipeline, in order that the entire pipeline
> +can be managed as a single job.
>  cindex(background jobs, I/O)
>  cindex(jobs, background, I/O)
>  Background jobs are normally allowed to produce output,

Now I'm thinking whether there should be an option to control that.
Indeed, some functions may fail to work correctly if they are suspended
in such a way. Some functions or { list } could be marked as not
backgroundable, e.g. by setting an option at the beginning, in which
case the ^Z could be ignored.

What happens if a TSTP signal is received while a completion function
is run or something like that?

-- 
Vincent Lefèvre <vincent@vinc17.net> - Web: <http://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <http://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)


  reply	other threads:[~2012-02-20 16:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-20 13:02 Vincent Lefevre
2012-02-20 15:13 ` Peter Stephenson
2012-02-20 16:09   ` Vincent Lefevre [this message]
2012-02-20 16:35     ` Peter Stephenson
2012-02-20 17:41       ` Bart Schaefer
2012-02-20 18:33         ` Vincent Lefevre
2012-02-20 18:53           ` Bart Schaefer
2012-02-20 19:21             ` Vincent Lefevre
2012-02-20 19:48             ` Mikael Magnusson
2012-02-21  3:27               ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120220160944.GC7797@xvii.vinc17.org \
    --to=vincent@vinc17.net \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).