From: Peter Stephenson <Peter.Stephenson@csr.com>
To: <zsh-workers@zsh.org>
Subject: Re: Certain unicode in hostname breaks with zsh 4.3.17
Date: Mon, 12 Mar 2012 17:11:40 +0000 [thread overview]
Message-ID: <20120312171140.541da84a@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <120312100737.ZM22728@torch.brasslantern.com>
On Mon, 12 Mar 2012 10:07:37 -0700
Bart Schaefer <schaefer@brasslantern.com> wrote:
> On Mar 12, 11:10am, Peter Stephenson wrote:
> >
> > @@ -739,7 +741,7 @@ createparamtable(void)
> > pm->env = mkenvstr (pm->node.nam,
> > getsparam(pm->node.nam), pm->node.flags);
> > else
> > - pm->env = ztrdup(*envp2);
> > + pm->env = ztrdup_metafy(*envp2);
> > #ifndef USE_SET_UNSET_ENV
> > *envp++ = pm->env;
> > #endif
>
> I'm not sure that's correct. pm->env is being copied directly into the
> global environ array in the USE_SET_UNSET_ENV case.
Yes, you're right, so that shouldn't be metafied and I'll correct that
bit.
--
Peter Stephenson <pws@csr.com> Software Engineer
Tel: +44 (0)1223 692070 Cambridge Silicon Radio Limited
Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, UK
Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom
More information can be found at www.csr.com. Follow CSR on Twitter at http://twitter.com/CSR_PLC and read our blog at www.csr.com/blog
next prev parent reply other threads:[~2012-03-12 18:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-11 5:10 Kevin N.
2012-03-11 16:39 ` Phil Pennock
2012-03-11 19:08 ` Bart Schaefer
2012-03-11 19:17 ` Bart Schaefer
2012-03-11 19:20 ` Mikael Magnusson
2012-03-11 21:19 ` Bart Schaefer
2012-03-11 21:28 ` Mikael Magnusson
2012-03-12 3:56 ` Bart Schaefer
2012-03-12 10:08 ` Peter Stephenson
2012-03-12 11:10 ` Peter Stephenson
2012-03-12 17:07 ` Bart Schaefer
2012-03-12 17:11 ` Peter Stephenson [this message]
2012-03-12 10:56 ` Mikael Magnusson
2012-03-12 10:59 ` Mikael Magnusson
2012-03-12 11:02 ` Mikael Magnusson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120312171140.541da84a@pwslap01u.europe.root.pri \
--to=peter.stephenson@csr.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).