From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-30353-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 19372 invoked by alias); 12 Mar 2012 18:01:54 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 30353
Received: (qmail 11422 invoked from network); 12 Mar 2012 18:01:51 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,
	SPF_HELO_PASS autolearn=ham version=3.3.2
Received-SPF: none (ns1.primenet.com.au: domain at csr.com does not designate permitted sender hosts)
Date: Mon, 12 Mar 2012 17:11:40 +0000
From: Peter Stephenson <Peter.Stephenson@csr.com>
To: <zsh-workers@zsh.org>
Subject: Re: Certain unicode in hostname breaks with zsh 4.3.17
Message-ID: <20120312171140.541da84a@pwslap01u.europe.root.pri>
In-Reply-To: <120312100737.ZM22728@torch.brasslantern.com>
References: <CAGO9HBhuTRJtxLvYgn3bgQ-1XO9OmEnE0SHmxzyWvwGPX_1V=g@mail.gmail.com>
	<CAH+w=7aqJcqgE=Oq_8CvrfCJazACVcXBHALP5YhBw6qR-ND=eA@mail.gmail.com>
	<CAH+w=7YptzOCFwG3u3g-CvyyenDUFea8rpm7o5g6gzyFzJGx7w@mail.gmail.com>
	<CAHYJk3TbR4S8NLbH7rut_uf0OBJg_vDzpZFwAqwoDcDBUkab7A@mail.gmail.com>
	<120311141935.ZM12005@torch.brasslantern.com>
	<CAHYJk3Q6RYa2gMQGy1Jr98zj3OxQzKMGGiUmcor=BMHcH46NgQ@mail.gmail.com>
	<120311205638.ZM21245@torch.brasslantern.com>
	<20120312100831.0bb82360@pwslap01u.europe.root.pri>
	<20120312111028.7b1edca2@pwslap01u.europe.root.pri>
	<120312100737.ZM22728@torch.brasslantern.com>
Organization: Cambridge Silicon Radio
X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.101.10.170]
X-Scanned-By: MailControl 7.6.6 (www.mailcontrol.com) on 10.71.0.143

On Mon, 12 Mar 2012 10:07:37 -0700
Bart Schaefer <schaefer@brasslantern.com> wrote:
> On Mar 12, 11:10am, Peter Stephenson wrote:
> >
> > @@ -739,7 +741,7 @@ createparamtable(void)
> >  			pm->env = mkenvstr (pm->node.nam,
> >  					    getsparam(pm->node.nam), pm->node.flags);
> >  		    else
> > -			pm->env = ztrdup(*envp2);
> > +			pm->env = ztrdup_metafy(*envp2);
> >  #ifndef USE_SET_UNSET_ENV
> >  		    *envp++ = pm->env;
> >  #endif
> 
> I'm not sure that's correct.  pm->env is being copied directly into the
> global environ array in the USE_SET_UNSET_ENV case.

Yes, you're right, so that shouldn't be metafied and I'll correct that
bit.

-- 
Peter Stephenson <pws@csr.com>            Software Engineer
Tel: +44 (0)1223 692070                   Cambridge Silicon Radio Limited
Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, UK


Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom
More information can be found at www.csr.com. Follow CSR on Twitter at http://twitter.com/CSR_PLC and read our blog at www.csr.com/blog