From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: Stephane Chazelas <stephane.chazelas@gmail.com>,
"zsh-workers@zsh.org" <zsh-workers@zsh.org>
Subject: Re: Problems with zargs (Was: xargs should be a builtin)
Date: Wed, 11 Apr 2012 17:15:39 +0100 [thread overview]
Message-ID: <20120411171539.4a09da6a@pws-pc.ntlworld.com> (raw)
In-Reply-To: <20120411100642.GA8180@chaz.gmail.com>
On Wed, 11 Apr 2012 11:06:42 +0100
Stephane Chazelas <stephane.chazelas@gmail.com> wrote:
> By the way, there seems to be some issues with zargs:
>
> ~$ zargs a b '' -- print -rl
> a
> b
> ~$ zargs a -- print -rl ''
> a
> ~$ zargs -e a '' print -rl
> a print -rl
> ~$ zargs --eof= a '' print -rl
> a
It helps if everyone always says explicitly what the problem actually
is, it saves lots of guesswork.
I've come up with the following for the problems I understand, but I'm
sure it could do with a bit more prodding.
Index: Functions/Misc/zargs
===================================================================
RCS file: /cvsroot/zsh/zsh/Functions/Misc/zargs,v
retrieving revision 1.6
diff -p -u -r1.6 zargs
--- Functions/Misc/zargs 14 Aug 2011 13:40:53 -0000 1.6
+++ Functions/Misc/zargs 11 Apr 2012 16:14:48 -0000
@@ -167,11 +167,11 @@ if [[ $eof == -(e|-eof) ]]; then ((end=A
elif (( $#eof )); then end=$argv[(i)${eof##-(e|-eof=)}]
else end=$argv[(i)--]
fi
-local -a args call command; command=( ${argv[end+1,-1]} )
+local -a args call command; command=( "${(@)argv[end+1,-1]}" )
if (( $opts[(I)-(null|0)] ))
-then set -- ${(ps:\000:)argv[1,end-1]}
-else set -- $argv[1,end-1]
+then set -- "${(@ps:\000:)argv[1,end-1]}"
+else set -- "${(@)argv[1,end-1]}"
fi
if [[ -n $command ]]
@@ -187,7 +187,7 @@ local execute='
then print -u2 -r -- "$call"
fi
eval "{
- \$call
+ \"\${(@)call}\"
} $bg"'
local ret=0 analyze='
case $? in
@@ -275,11 +275,11 @@ do
((ARGC)) || break
for (( end=l; end && ${(c)#argv[1,end]} > s; end/=2 )) { }
(( end > n && ( end = n ) ))
- args=( $argv[1,end] )
+ args=( "${(@)argv[1,end]}" )
shift $((end > ARGC ? ARGC : end))
if (( $#i ))
- then call=( ${command/$i/$args} )
- else call=( $command $args )
+ then call=( "${(@)command/$i/$args}" )
+ else call=( "${(@)command}" "${(@)args}" )
fi
if (( ${(c)#call} > s ))
then
--
Peter Stephenson <p.w.stephenson@ntlworld.com>
Web page now at http://homepage.ntlworld.com/p.w.stephenson/
next prev parent reply other threads:[~2012-04-11 16:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-11 7:31 xargs should be a builtin Dave Yost
2012-04-11 7:44 ` Frank Terbeck
2012-04-11 10:06 ` Problems with zargs (Was: xargs should be a builtin) Stephane Chazelas
2012-04-11 16:15 ` Peter Stephenson [this message]
2012-04-12 9:28 ` Stephane Chazelas
2012-04-12 19:33 ` Peter Stephenson
[not found] ` <CAH+w=7Z5pUmqxpURyHMA5FX3hMGoyQeYwbC1N7AO6Ow-D=P-gw@mail.gmail.com>
[not found] ` <20120413201325.64cfcd1f@pws-pc.ntlworld.com>
2012-04-14 17:01 ` Bart Schaefer
2012-04-12 23:05 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120411171539.4a09da6a@pws-pc.ntlworld.com \
--to=p.w.stephenson@ntlworld.com \
--cc=stephane.chazelas@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).