From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-30410-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 9195 invoked by alias); 14 Apr 2012 20:55:52 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 30410
Received: (qmail 13328 invoked from network); 14 Apr 2012 20:55:40 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW
	autolearn=ham version=3.3.2
Received-SPF: neutral (ns1.primenet.com.au: 74.125.82.171 is neither permitted nor denied by SPF record at ntlworld.com)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=google.com; s=20120113;
        h=x-proxyuser-ip:date:from:to:subject:message-id:in-reply-to
         :references:x-mailer:mime-version:content-type
         :content-transfer-encoding:x-gm-message-state;
        bh=jl2vsyyhwbqf0GdA7vz5/EIuShJ9Eb7EDBltJcGK07g=;
        b=JdlXxFj3CF9Y+QVZr2vyR2r6eBn3pPp32/BX4ywWHXrSehwC4f18Pp003PoZdXyeH3
         CK7hHXStKLnAMLZAm43gYAk33A9CNcpkr11YGAtXZr9TWu0EO8NpWOKGenPlnZoo7PWE
         1ovuaw1Mgg/PUMrXZuSJZcT8f33JwzQhK97IX9qPJOjuDh2CPhmh2S3yDL71nRawry4k
         RWrKUZSGd2cq4ZKcDMNKwihG3enP0CgpmTQS76KixxF3PyOQ6tCO+XRdRc495MJrKpI8
         jyzsRv+Ijz0GZU+iEIR88XbWJeBvdWZV5s5lhjHLv8vHDuNLRxxBuhm+43ucXU0MxpbP
         yhKw==
X-ProxyUser-IP: 86.6.29.42
Date: Sat, 14 Apr 2012 21:55:28 +0100
From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: zsh-workers@zsh.org
Subject: Re: manpage mentions old TIMEFMT
Message-ID: <20120414215528.2cb405fa@pws-pc.ntlworld.com>
In-Reply-To: <87lilyz8mn.fsf@gmail.com>
References: <87ty0nz7dn.fsf@gmail.com>
	<87pqbbz62r.fsf@gmail.com>
	<20120413233544.40d9fb2a@pws-pc.ntlworld.com>
	<87lilyz8mn.fsf@gmail.com>
X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.7; x86_64-redhat-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Gm-Message-State: ALoCoQnbjhqoTRE0lGan2FRGR7DVYTPUM7ZZL5zQ38uVs7uBVnseeoG5uzctVCKa7fCwu6fAa2+c

On Sat, 14 Apr 2012 16:32:48 +0200
Christian Neukirchen <chneukirchen@gmail.com> wrote:
> >> Finally, %X and %D are rubbish on Linux (but GNU time(1) always shows
> >> 0 for them).
> 
> I'd prefer if they were 0 instead of -9223372036854775808...

I don't know where this is coming from, but the shell does initialise
the structure when it's created, so something in the shell is actually
setting a value --- unless it's the effect of dividing by a zero total
time.

Index: Src/jobs.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/jobs.c,v
retrieving revision 1.88
diff -p -u -r1.88 jobs.c
--- Src/jobs.c	28 Aug 2011 16:38:28 -0000	1.88
+++ Src/jobs.c	14 Apr 2012 20:53:31 -0000
@@ -716,17 +716,22 @@ printtime(struct timeval *real, child_ti
 #endif
 #ifdef HAVE_STRUCT_RUSAGE_RU_IXRSS
 	    case 'X':
-		fprintf(stderr, "%ld", (long)(ti->ru_ixrss / total_time));
+		fprintf(stderr, "%ld", 
+			total_time ?
+			(long)(ti->ru_ixrss / total_time) :
+			(long)0);
 		break;
 #endif
 #ifdef HAVE_STRUCT_RUSAGE_RU_IDRSS
 	    case 'D':
 		fprintf(stderr, "%ld",
+			total_time ? 
 			(long) ((ti->ru_idrss
 #ifdef HAVE_STRUCT_RUSAGE_RU_ISRSS
 				 + ti->ru_isrss
 #endif
-				    ) / total_time));
+				    ) / total_time) :
+			(long)0);
 		break;
 #endif
 #if defined(HAVE_STRUCT_RUSAGE_RU_IDRSS) || \


-- 
Peter Stephenson <p.w.stephenson@ntlworld.com>
Web page now at http://homepage.ntlworld.com/p.w.stephenson/