From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-30463-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 10424 invoked by alias); 2 May 2012 11:34:28 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 30463
Received: (qmail 6030 invoked from network); 2 May 2012 11:34:26 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,
	SPF_HELO_PASS autolearn=ham version=3.3.2
Received-SPF: none (ns1.primenet.com.au: domain at csr.com does not designate permitted sender hosts)
Date: Wed, 2 May 2012 11:56:50 +0100
From: Peter Stephenson <Peter.Stephenson@csr.com>
To: <zsh-workers@zsh.org>
Subject: Re: PATCH: Fix some more missing locals for $match
Message-ID: <20120502115650.6c519661@pwslap01u.europe.root.pri>
In-Reply-To: <1335955692-4359-1-git-send-email-mikachu@gmail.com>
References: <1335954913-3709-1-git-send-email-mikachu@gmail.com>
	<1335955692-4359-1-git-send-email-mikachu@gmail.com>
Organization: Cambridge Silicon Radio
X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.101.10.18]
X-Scanned-By: MailControl 7.7.0.1 (www.mailcontrol.com) on 10.68.0.126

On Wed, 2 May 2012 12:48:12 +0200
Mikael Magnusson <mikachu@gmail.com> wrote:
> +local -a match

Ideally, these should always be

local -a match mbegin mend

because all three are set, even though the other two aren't used
anything like as much.

-- 
Peter Stephenson <pws@csr.com>            Software Engineer
Tel: +44 (0)1223 692070                   Cambridge Silicon Radio Limited
Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, UK


Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom
More information can be found at www.csr.com. Follow CSR on Twitter at http://twitter.com/CSR_PLC and read our blog at www.csr.com/blog