zsh completion for "svn" is obsolete

zsh completion for "svn" is obsolete

[Yann Ollivier]

Hello,

The completion functions for "svn" seem to be broken since subversion 1.7. 
For instance if you hit "svn add <TAB>", it will complete all files in the 
current directory, while it used to complete only those files not under 
subversion control. Likewise, if you hit "svn remove <TAB>" it used to 
complete all files under subversion control, but now returns only 
subdirectories (or all files if there are no subdirectories).

This affects at least zsh 5.0.0 and 5.0.2.

The reason is: the helper functions in
zsh/functions/Completion/Unix/_subversion
are obsolete. They all rely on the presence of ".svn" subdirectories in 
all directories under version control, whereas since subversion 1.7 these 
directories have been removed and the list of versioned files is 
maintained as a database in $HOME/.svn

A related issue has been discussed and fixed in the past 
(completion after hitting "svn <TAB>"), but this one seems to be still 
unresolved.

Thanks!

             Yann Ollivier

Re: zsh completion for "svn" is obsolete

[Vincent Lefevre]

On 2013-01-02 13:25:58 +0100, Yann Ollivier wrote:
> The completion functions for "svn" seem to be broken since subversion 1.7.
> For instance if you hit "svn add <TAB>", it will complete all files in the
> current directory, while it used to complete only those files not under
> subversion control.
[...]

I've noticed that too. But it was supposed to be fixed in 5.0.0:

  http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=679345#14

In the changelog:

2011-12-30  Frank Terbeck  <ft@bewatermyfriend.org>
[...]
        * 30046: Functions/VCS_Info/Backends/VCS_INFO_get_data_svn: Fix
        support for subversion version 1.7.

-- 
Vincent Lefèvre <vincent@vinc17.net> - Web: <http://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <http://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

Re: zsh completion for "svn" is obsolete

[Frank Terbeck]

Vincent Lefevre wrote:
> On 2013-01-02 13:25:58 +0100, Yann Ollivier wrote:
>> The completion functions for "svn" seem to be broken since subversion 1.7.
>> For instance if you hit "svn add <TAB>", it will complete all files in the
>> current directory, while it used to complete only those files not under
>> subversion control.
[...]
> In the changelog:
>
> 2011-12-30  Frank Terbeck  <ft@bewatermyfriend.org>
> [...]
>         * 30046: Functions/VCS_Info/Backends/VCS_INFO_get_data_svn: Fix
>         support for subversion version 1.7.

Well, this particular change is the subversion 1.7 support in the
vcs_info backend. The completion function is not related to it in
any way.

A quick look didn't reveal any changes in the `_subversion' completion
with respect the subversion's 1.7 release.

Regards, Frank

Re: zsh completion for "svn" is obsolete

[Axel Beckert]

Hi,

On Mon, Jan 14, 2013 at 11:29:06AM +0100, Vincent Lefevre wrote:
> On 2013-01-02 13:25:58 +0100, Yann Ollivier wrote:
> > The completion functions for "svn" seem to be broken since subversion 1.7.
> > For instance if you hit "svn add <TAB>", it will complete all files in the
> > current directory, while it used to complete only those files not under
> > subversion control.
> [...]
> 
> I've noticed that too. But it was supposed to be fixed in 5.0.0:
>
>   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=679345#14
>
> In the changelog:
> 
> 2011-12-30  Frank Terbeck  <ft@bewatermyfriend.org>
> [...]
>         * 30046: Functions/VCS_Info/Backends/VCS_INFO_get_data_svn: Fix
>         support for subversion version 1.7.

On Wed, Jan 02, 2013 at 01:25:58PM +0100, Yann Ollivier wrote:
> A related issue has been discussed and fixed in the past (completion
> after hitting "svn <TAB>"), but this one seems to be still
> unresolved.

Hrm, I'm now confused. No idea anymore what made me convinced that
this has been fixed anymore. Workers 30046
(http://www.zsh.org/mla/workers/2011/msg01464.html), cited above by
Vincent has nothing to do with completion, just with VCS_Info. But
maybe I considered that commit to be the fix despite its from 2011 and
pre-4.3.17 (the bug has been reported against 4.3.17). The only
svn-related thing between 4.3.17 and 5.0.0 was "30197: complete
subversion changelists". I'm sorry for the mixup.

But this also means I've no idea to which commit Yann refers to.

In the end, svn 1.7 completion is still open, with two reports:
Workers 30963 (by Vincent against the Debian package, forwarded by me
to zsh-workers: http://www.zsh.org/mla/workers/2013/msg00026.html) and
Workers 30539 (by Yann, directly:
http://www.zsh.org/mla/workers/2012/msg00460.html)

		Kind regards, Axel
-- 
/~\  Plain Text Ribbon Campaign                   | Axel Beckert
\ /  Say No to HTML in E-Mail and News            | abe@deuxchevaux.org  (Mail)
 X   See http://www.asciiribbon.org/              | abe@noone.org (Mail+Jabber)
/ \  I love long mails: http://email.is-not-s.ms/ | http://noone.org/abe/ (Web)

Bug#679345: Info received (zsh completion for "svn" is obsolete)

[Debian Bug Tracking System]

Thank you for the additional information you have supplied regarding
this Bug report.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 Debian Zsh Maintainers <pkg-zsh-devel@lists.alioth.debian.org>

If you wish to submit further information on this problem, please
send it to 679345@bugs.debian.org.

Please do not send mail to owner@bugs.debian.org unless you wish
to report a problem with the Bug-tracking system.

-- 
679345: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=679345
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems