From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4530 invoked by alias); 10 Apr 2013 00:24:00 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 31249 Received: (qmail 21929 invoked from network); 10 Apr 2013 00:23:58 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 Received-SPF: pass (ns1.primenet.com.au: SPF record at ruderich.org designates 178.63.68.96 as permitted sender) Date: Wed, 10 Apr 2013 02:23:49 +0200 From: Simon Ruderich To: zsh-workers@zsh.org Subject: Re: version.h and ChangeLog Message-ID: <20130410002349.GA2239@ruderich.org> References: <130407103829.ZM487@torch.brasslantern.com> <20130407192324.5bde3a2b@pws-pc.ntlworld.com> <87bo9pnr1n.fsf@ft.bewatermyfriend.org> <20130408203413.43e20021@pws-pc.ntlworld.com> <20130408220207.4c02af51@pws-pc.ntlworld.com> <20130409164722.GA24778@ruderich.org> <20130409201852.GA58314@redoubt.spodhuis.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="=_zucker.schokokeks.org-19216-1365553430-0001-2" Content-Disposition: inline In-Reply-To: <20130409201852.GA58314@redoubt.spodhuis.org> User-Agent: Mutt/1.5.21 (2013-03-19) --=_zucker.schokokeks.org-19216-1365553430-0001-2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 09, 2013 at 04:18:52PM -0400, Phil Pennock wrote: > On 2013-04-09 at 18:47 +0200, Simon Ruderich wrote: >> Appending something like "-local-" is difficult because >> what's considered local depends on how Git is used. We could >> check "origin"/master but what if I call the remote branch >> "upstream"? > > At some point, the onus of work shifts to the person who is violating > convention. I mean, I might have used stty to remap intr to ^R. Most > tools are entitled to assume that intr is ^C without bothering to check. > Still, robust tooling might support the unusual. > > [snip] Hello Phil, Isn't that over-engineering for such a rarely relevant case? Most people who use a Git checkout (should) understand that local commits are not known to the rest of the world and that therefore the `git describe` output is not meaningful in this case. And everybody on the mailing list can use `git merge --contains` to check if the reporter's Zsh is based on a public commit and if not ask him to rebuild it. I'd recommend that we keep it simple and extend it only if it's really necessary. Regards Simon --=20 + privacy is necessary + using gnupg http://gnupg.org + public key id: 0x92FEFDB7E44C32F9 --=_zucker.schokokeks.org-19216-1365553430-0001-2 Content-Type: application/pgp-signature; name="signature.asc" Content-Transfer-Encoding: 7bit Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBCgAGBQJRZLEVAAoJEJL+/bfkTDL5LgcP/1mHqUqKiAnb7Ng+DP6dKCVf 5sew3pIJBqw8ZjKaaM1QIbsVVVYO/m5ASsiTPQPBUl+xLmymzs+NJ1hBm8qKw70w GAR87O5m6z930N8Ry6hjedGNIkugpAjZYpqmX3dc1v6HQfZqfWqe3LgNNvYRbUlD FRDeJoN74Ew8GLODlZoiIHE2iqieIHq+XPA1EFzvJLHQwR0Kwl++9TU5SQL0HMqc YsxogIift3EOuR3onhf72A9eG+Nunkf9jeiJPIq5R7oNUcumlmInMRKWvxEfN4X+ qx0ALzfTOL/BjF5qTSleogJtYGQZ5N8GVlPmnTRLRRXIOBpcIekFNwHzNdYgqVqJ +KyHXyLNTHhhS5ghwyi9Eu6XYusO/epxdDICw9YRun/H6u+31WvohZ2HYotSIObX 3cHqKs1XiWeHK2+bq0IIiueQK7kjBNzdOJpG6HY4+wLWGSw97PV5zh6jIxRcj2IS WF+YYs/BH9a5hxIKqgws/aqFk4vpmLVoAySPeRMO5OYwWW3gRzuVX2AAC3+O3nlA 8CLpwYFcTHyzlj2m70cGBlrCrDK1E2cV1JVpzuOh+PEivlj+jCj4inRrwAxs30Zc gxKVpP3sydLjjattRhx9RdWt1c+eByOaZnfdz6c2r5tW1/5R+cjeglIw9V1eS1rq aweKStmJaw71GnMqYYf1 =hoOt -----END PGP SIGNATURE----- --=_zucker.schokokeks.org-19216-1365553430-0001-2--