zsh-workers
 help / color / mirror / code / Atom feed
From: Phil Pennock <zsh-workers+phil.pennock@spodhuis.org>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: Quick local CVS change scan, and bug in read?
Date: Sat, 18 May 2013 21:29:02 -0400	[thread overview]
Message-ID: <20130519012902.GA83443@redoubt.spodhuis.org> (raw)
In-Reply-To: <CAH+w=7YQLJZGxjdA=ZwA_u+JJg=LcGPRkPExj5bNcXRhX6hZUg@mail.gmail.com>

On 2013-05-18 at 16:24 -0700, Bart Schaefer wrote:
> useful.  (One of the few things I'm finding annoying about git is that
> a cloned repository doesn't preserve file timestamps.)

There's a post-checkout hook in one of the answers on
<http://stackoverflow.com/questions/1964470/whats-the-equivalent-of-use-commit-times-for-git>
which might help?

> Another problem is that the %e format in strftime is supposed to
> prefix single-digit dates with a space, but zstat doesn't consistently
> do that, which makes the date comparison more difficult than
> necessary.  For example, the leading space is present on CentOS 5 for
> zsh 4.2.6 and MacOS Lion zsh version 4.3.11, but is missing on Ubuntu
> 10.04 zsh 4.3.10.  It's also present in a fresh build of
> zsh-5.0.2-88-gaa7467b on Unbutu, so I presume this to be some kind of
> strange build-specific issue.

stattimeprint() uses ztrftime() and so should be portable across OSes;
%e is implemented by zsh logic and is very explicit in handling
%providing the space unless you used %-e.

I can see that on *old* builds it would fail; when %-<foo> support was
added in 535afe3b by pws on 2009-Mar-02 [26614 + 26615] it looks like it
made %e always strip the space; then in 506c845b on 2009-Jun-26 it was
fixed with 27057:

+       * Greg Klanderman: 27057: Src/utils.c: %e and %f time formats
+       were swapped.

4.3.10 was 2009-06-01.  4.3.9 was in 2008.  4.3.11 in 2010.

So the only release cut with this bug was 4.3.10.

That seems to match your observations?

-Phil


  reply	other threads:[~2013-05-19  1:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-18 23:24 Bart Schaefer
2013-05-19  1:29 ` Phil Pennock [this message]
2013-05-19  4:26   ` Bart Schaefer
2013-05-19  5:36     ` Phil Pennock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130519012902.GA83443@redoubt.spodhuis.org \
    --to=zsh-workers+phil.pennock@spodhuis.org \
    --cc=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).