zsh-workers
 help / color / mirror / code / Atom feed
* [PATCH] Update .editorconfig file: comment lines should occupy individual lines
@ 2013-06-08  7:32 Hong Xu
  2013-06-08 18:45 ` Aaron Schrab
  0 siblings, 1 reply; 3+ messages in thread
From: Hong Xu @ 2013-06-08  7:32 UTC (permalink / raw)
  To: zsh-workers

[-- Attachment #1: Type: text/plain, Size: 182 bytes --]

Hi All,

The attachment fixes an issue of the .editorconfig file in the zsh 
repository: comments should occupy individual lines, but not be appended 
to another line.

Thanks,
Hong

[-- Attachment #2: editorconfig.patch --]
[-- Type: text/plain, Size: 242 bytes --]

diff --git a/.editorconfig b/.editorconfig
index 58421c0..145dc37 100644
--- a/.editorconfig
+++ b/.editorconfig
@@ -1,4 +1,6 @@
-root = true  # Top-most editorconfig file
+# Top-most editorconfig file
+
+root = true
 
 [*]
 end_of_line = lf

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re:  Update .editorconfig file: comment lines should occupy individual lines
  2013-06-08  7:32 [PATCH] Update .editorconfig file: comment lines should occupy individual lines Hong Xu
@ 2013-06-08 18:45 ` Aaron Schrab
  2013-06-08 18:52   ` Hong Xu
  0 siblings, 1 reply; 3+ messages in thread
From: Aaron Schrab @ 2013-06-08 18:45 UTC (permalink / raw)
  To: Hong Xu; +Cc: zsh-workers

At 00:32 -0700 08 Jun 2013, Hong Xu <hong@topbug.net> wrote:
>The attachment fixes an issue of the .editorconfig file in the zsh 
>repository: comments should occupy individual lines, but not be 
>appended to another line.

Responding as the person who originally submitted the .editorconfig file 
here.

The file format details section of the editorconfig website doesn't say 
anything about comments needing to be on separate lines, I guess that's 
expected to be understood when it states that the format is based on INI 
files.  I'd say that should be clarified.

But, since you're one of the initiators of the format, I'll defer to you 
on that detail.  At worst, having an extra newline certainly shouldn't 
hurt anything.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Update .editorconfig file: comment lines should occupy individual lines
  2013-06-08 18:45 ` Aaron Schrab
@ 2013-06-08 18:52   ` Hong Xu
  0 siblings, 0 replies; 3+ messages in thread
From: Hong Xu @ 2013-06-08 18:52 UTC (permalink / raw)
  To: zsh-workers

On 6/8/13 11:45 AM, Aaron Schrab wrote:
> At 00:32 -0700 08 Jun 2013, Hong Xu <hong@topbug.net> wrote:
>> The attachment fixes an issue of the .editorconfig file in the zsh
>> repository: comments should occupy individual lines, but not be
>> appended to another line.
>
> Responding as the person who originally submitted the .editorconfig file
> here.
>
> The file format details section of the editorconfig website doesn't say
> anything about comments needing to be on separate lines, I guess that's
> expected to be understood when it states that the format is based on INI
> files.  I'd say that should be clarified.
>
> But, since you're one of the initiators of the format, I'll defer to you
> on that detail.  At worst, having an extra newline certainly shouldn't
> hurt anything.

Yeah, you're right, the detail isn't on the website. Actually this was a 
mistake that we made. I'll add the details to the website.

Thanks,

Hong


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-06-08 18:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-08  7:32 [PATCH] Update .editorconfig file: comment lines should occupy individual lines Hong Xu
2013-06-08 18:45 ` Aaron Schrab
2013-06-08 18:52   ` Hong Xu

Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).