zle and unicode (run-help triggered issue)

zle and unicode (run-help triggered issue)

[Phil Pennock]

Being occasionally frivolous, a while ago I set up ☛ (BLACK RIGHT
POINTING INDEX) as an alias for a command I use fairly often.  Heck,
even with digraphs, it works out to be one fewer keystrokes.

Invoking the widget which calls run-help ends up corrupting the unicode
somewhat; I'm wondering if some unmetafy is missing somewhere?  This,
being ZLE, is way outside the areas of zsh I know much about.

zsh 5.0.2, "ilmenite" is a MacOS laptop, "redoubt" is ssh'd into a BSD
machine (from ilmenite) with locale set up correctly for UTF-8 to "just
work".  I'm pasting ☛ into the "zsh -f" to avoid setting up digraphs in
-f, I'm using bindkey to get the run-help onto Esc-H, and am entering ☛,
a space, and then Esc-H.

ilmenite% bindkey -e
ilmenite% run-help ☛
翐<4b82a689>翐
No manual entry for ☛
ilmenite% 

redoubt% bindkey -e
redoubt% run-help ☛^@^@<005abb18>^@
No manual entry for ☛
redoubt%

The exact text shown changes between shell invocations and sometimes if
I run a different command, but tends to latch onto one sequence, perhaps
showing inverse ^@ (NUL) four times afterwards; the off-by-four is what
leads me to suspect unmetafy issues.

Any ideas?
-Phil

Re: zle and unicode (run-help triggered issue)

[Peter Stephenson]

On Wed, 7 Aug 2013 15:35:55 -0400
Phil Pennock <zsh-workers+phil.pennock@spodhuis.org> wrote:
> Being occasionally frivolous, a while ago I set up ☛ (BLACK RIGHT
> POINTING INDEX) as an alias for a command I use fairly often.  Heck,
> even with digraphs, it works out to be one fewer keystrokes.
> 
> Invoking the widget which calls run-help ends up corrupting the unicode
> somewhat; I'm wondering if some unmetafy is missing somewhere?

diff --git a/Src/Zle/zle_tricky.c b/Src/Zle/zle_tricky.c
index 610055c..e30e0b1 100644
--- a/Src/Zle/zle_tricky.c
+++ b/Src/Zle/zle_tricky.c
@@ -2136,8 +2136,8 @@ inststrlen(char *str, int move, int len)
 	return 0;
     if (len == -1)
 	len = strlen(str);
-    spaceinline(len);
     if (zlemetaline != NULL) {
+	spaceinline(len);
 	strncpy(zlemetaline + zlemetacs, str, len);
 	if (move)
 	    zlemetacs += len;
@@ -2148,6 +2148,7 @@ inststrlen(char *str, int move, int len)
 
 	instr = ztrduppfx(str, len);
 	zlestr = stringaszleline(instr, 0, &zlelen, NULL, NULL);
+	spaceinline(zlelen);
 	ZS_strncpy(zleline + zlecs, zlestr, zlelen);
 	free(zlestr);
 	zsfree(instr);

-- 
Peter Stephenson <p.w.stephenson@ntlworld.com>
Web page now at http://homepage.ntlworld.com/p.w.stephenson/

Re: zle and unicode (run-help triggered issue)

[Phil Pennock]

On 2013-08-08 at 20:05 +0100, Peter Stephenson wrote:
> On Wed, 7 Aug 2013 15:35:55 -0400
> Phil Pennock <zsh-workers+phil.pennock@spodhuis.org> wrote:
> > Being occasionally frivolous, a while ago I set up ☛ (BLACK RIGHT
> > POINTING INDEX) as an alias for a command I use fairly often.  Heck,
> > even with digraphs, it works out to be one fewer keystrokes.
> > 
> > Invoking the widget which calls run-help ends up corrupting the unicode
> > somewhat; I'm wondering if some unmetafy is missing somewhere?
> 
> diff --git a/Src/Zle/zle_tricky.c b/Src/Zle/zle_tricky.c
> index 610055c..e30e0b1 100644

Confirmed to fix it for me.  Great, thanks.  :)

-Phil