zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: zsh-workers@zsh.org
Subject: Re: patch to mailcheck missing new emails
Date: Sat, 10 Aug 2013 19:51:38 +0100	[thread overview]
Message-ID: <20130810195138.3472046a@pws-pc.ntlworld.com> (raw)
In-Reply-To: <CAHjjW159o_K=ASiDKCvZ38EnAKhvm9_91V0oewpas1AVtH0VOw@mail.gmail.com>

On Fri, 9 Aug 2013 14:54:29 -0500
joe M <joe9mail@gmail.com> wrote:
> I am noticing that mailcheck is missing some emails while comparing
> the files' modification time with the lastmailcheck. It is also
> missing any emails created/received while the mailcheck process is
> running.
> 
> I am attaching the patch that fixes the issue. This is my first patch
> to zsh, hence, am not sure if it adheres to any guidelines.

Thanks, that looks very plausible and I've committed it (with a couple
of entirely cosmetic changes).

(Separate issue noted in passing: we should probably use zlong for
period and mailcheck to be safe; efficiency isn't really an issue.)

-- 
Peter Stephenson <p.w.stephenson@ntlworld.com>
Web page now at http://homepage.ntlworld.com/p.w.stephenson/


  reply	other threads:[~2013-08-10 18:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-09 19:54 joe M
2013-08-10 18:51 ` Peter Stephenson [this message]
2013-08-11 18:36   ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130810195138.3472046a@pws-pc.ntlworld.com \
    --to=p.w.stephenson@ntlworld.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).