From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-31736-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 19332 invoked by alias); 19 Sep 2013 09:00:18 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 31736
Received: (qmail 26421 invoked from network); 19 Sep 2013 09:00:03 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,
	SPF_HELO_PASS autolearn=ham version=3.3.2
Received-SPF: none (ns1.primenet.com.au: domain at samsung.com does not designate permitted sender hosts)
X-AuditID: cbfec7f5-b7ef66d00000795a-8d-523abab4db5e
Date: Thu, 19 Sep 2013 09:49:55 +0100
From: Peter Stephenson <p.stephenson@samsung.com>
To: zsh-workers@zsh.org
Subject: Re: Segfault on "task <Tab><Tab>" with zsh 5.0.2 [PATCH]
Message-id: <20130919094955.56c23268@pwslap01u.europe.root.pri>
In-reply-to: <20130918215003.GU3544@sym.noone.org>
References: <20130913122426.GA19439@sym.noone.org>
 <fa49a0192d7dd67145dfa34a783ec280@archlinux.de>
 <CAG2tFJzFpsy9H1ps5bvThD0n6bU8Zr0_9Z34Zy7MYsQeqdzL=Q@mail.gmail.com>
 <20130916171841.GG3544@sym.noone.org>
 <20130917095657.4cb4ccbf@pwslap01u.europe.root.pri>
 <20130917161058.GJ3544@sym.noone.org> <20130917163509.GK3544@sym.noone.org>
 <20130917200546.6094eb98@pws-pc.ntlworld.com>
 <130917200551.ZM14080@torch.brasslantern.com>
 <20130918215003.GU3544@sym.noone.org>
Organization: Samsung Cambridge Solution Centre
X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu)
MIME-version: 1.0
Content-type: text/plain; charset=US-ASCII
Content-transfer-encoding: 7bit
X-Brightmail-Tracker:
 H4sIAAAAAAAAA+NgFuplluLIzCtJLcpLzFFi42I5/e/4Nd0tu6yCDD7d57Y42PyQyYHRY9XB
	D0wBjFFcNimpOZllqUX6dglcGee/v2MuOMFcsfJHM2MD4yumLkYODgkBE4nFXVldjJxAppjE
	hXvr2boYuTiEBJYySmyY38IM4Sxnkvj/9BUzSBWLgKrE9u3rWEFsNgFDiambZjOC2CIC4hJn
	155nAbGFBRwl9pxYzgZi8wrYS5zZ2M0OYnMKGElc27CAHWLofWaJtm1HwYr4BfQlrv79xARx
	hr3EzCtnGCGaBSV+TL4HNpRZQEti87YmVghbXmLzmrfMExgFZiEpm4WkbBaSsgWMzKsYRVNL
	kwuKk9JzjfSKE3OLS/PS9ZLzczcxQoLw6w7GpcesDjEKcDAq8fBuuGQZJMSaWFZcmXuIUYKD
	WUmE9+tSqyAh3pTEyqrUovz4otKc1OJDjEwcnFINjBsXPOn4lDvvhEh4wXTX7XVX3FK3fzt6
	2+PGJvfSGqMGvnMcxjN5f1W1lW3JFtC9UspX9v2QeMV7pr7HvkL9EidvrS/1niy40Tbs4PQ/
	/Atuqsbz/P1lK3XqqsMB301REteOfu6ze/be8ZGAWfMH5sCkhdy169aGZiQV5Qluaf+hvtFi
	T3vMGSWW4oxEQy3mouJEAHa9wn0gAgAA

On Wed, 18 Sep 2013 23:50:04 +0200
Axel Beckert <abe@deuxchevaux.org> wrote:
> Below is a patch which fixes the issue for me. Read the whole
> mail for the reasoning.

Thanks for going through that. I've committed the patch.

The way i is decremented and p incremented at different points makes it
very difficult to see what's going on --- I suspect there's an argument
for moving the decrement just for clarity but this fix will do fine.

pws