From: Peter Stephenson <p.stephenson@samsung.com>
To: zsh-workers@zsh.org
Subject: Re: Strange function/pipestatus behavior, maybe a scope bug?
Date: Thu, 24 Oct 2013 17:03:52 +0100 [thread overview]
Message-ID: <20131024170352.053ead5f@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <20131024164829.55842279@pwslap01u.europe.root.pri>
On Thu, 24 Oct 2013 16:48:29 +0100
Peter Stephenson <p.stephenson@samsung.com> wrote:
> There is some bad interaction with completion, at least on my setup
> (happens from a vanilla setup, too):
>
> % true | true | false
> % print $pipest<TAB>
> 0
>
> This doesn't seem to happen with hooks, so completion is failing to save
> something it should.
Hmm... does the following have any bad effects? If we're really only
after the return value of the function, I don't think it should...
diff --git a/Src/Zle/compcore.c b/Src/Zle/compcore.c
index 39d41bd..5c5628a 100644
--- a/Src/Zle/compcore.c
+++ b/Src/Zle/compcore.c
@@ -826,7 +826,6 @@ callcompfunc(char *s, char *fn)
sfcontext = SFC_CWIDGET;
NEWHEAPS(compheap) {
LinkList largs = NULL;
- int olv = lastval;
if (*cfargs) {
char **p = cfargs;
@@ -836,9 +835,7 @@ callcompfunc(char *s, char *fn)
while (*p)
addlinknode(largs, dupstring(*p++));
}
- doshfunc(shfunc, largs, 0);
- cfret = lastval;
- lastval = olv;
+ cfret = doshfunc(shfunc, largs, 1);
} OLDHEAPS;
sfcontext = osc;
endparamscope();
pws
next prev parent reply other threads:[~2013-10-24 16:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 18:03 Ian F
2013-10-23 8:21 ` Peter Stephenson
2013-10-23 19:49 ` Ian F
2013-10-23 21:14 ` Peter Stephenson
2013-10-24 5:15 ` Bart Schaefer
2013-10-24 8:57 ` Peter Stephenson
2013-10-24 15:48 ` Peter Stephenson
2013-10-24 16:03 ` Peter Stephenson [this message]
2013-10-24 16:44 ` Bart Schaefer
2013-10-24 16:39 ` Bart Schaefer
2013-10-24 16:26 ` Bart Schaefer
2013-10-24 16:46 ` Peter Stephenson
2013-10-25 0:38 ` Bart Schaefer
2013-10-24 15:17 ` Jun T.
2013-10-24 16:25 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131024170352.053ead5f@pwslap01u.europe.root.pri \
--to=p.stephenson@samsung.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).