zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.stephenson@samsung.com>
To: zsh-workers@zsh.org
Subject: Re: zsh bug: isearch doesn't support unicode properly
Date: Mon, 28 Oct 2013 17:31:34 +0000	[thread overview]
Message-ID: <20131028173134.5a62ee5f@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <CAMvDr+TDSwQ2qkjjKcEH35rB7yukd_AvuMfkZ3jnwgrPq-oUyQ@mail.gmail.com>

On Mon, 28 Oct 2013 11:42:22 -0400
Yichao Yu <yyc1992@gmail.com> wrote:
> I've got a problem when typing unicode characters in the zsh's history search.
> 
> When trying to use unicode characters in isearch (the default binding
> for ^S and ^R), some of the unicode characters are not recognized
> correctly. For example, (with utf-8 encoding), when typing "重新安装"
> (utf-8 string: \xe9\x87\x8d\xe6\x96\xb0\xe5\xae\x89\xe8\xa3\x85)
> what's recognized by zsh is actually "駭涰宩裥" (utf-8 string:
> \xe9\xa7\xad\xe6\xb6\xb0\xe5\xae\xa9\xe8\xa3\xa5e). It seems that the
> fifth bit in one byte is flipped in come cases.
> 
> I'm not yet sure what's wrong with these characters but at least the
> meta character processing looks suspicious.

Yes --- how about this?

diff --git a/Src/Zle/zle_utils.c b/Src/Zle/zle_utils.c
index d0e7b55..b84d253 100644
--- a/Src/Zle/zle_utils.c
+++ b/Src/Zle/zle_utils.c
@@ -145,6 +145,7 @@ zlecharasstring(ZLE_CHAR_T inchar, char *buf)
 		ptr2--;
 	    }
 	    *ptr = Meta;
+	    ptr[1] ^= 32;
 	    ret++;
 	}
 
pws


  reply	other threads:[~2013-10-28 17:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-28 15:42 Yichao Yu
2013-10-28 17:31 ` Peter Stephenson [this message]
2013-10-28 17:53   ` Yichao Yu
2013-10-28 17:58     ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131028173134.5a62ee5f@pwslap01u.europe.root.pri \
    --to=p.stephenson@samsung.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).