From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8443 invoked by alias); 18 Nov 2013 10:53:00 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 32011 Received: (qmail 2875 invoked from network); 18 Nov 2013 10:52:54 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, SPF_HELO_PASS autolearn=ham version=3.3.2 X-AuditID: cbfec7f5-b7fe66d00000432e-00-5289ef2a1ccc Date: Mon, 18 Nov 2013 10:42:49 +0000 From: Peter Stephenson To: zsh-workers@zsh.org Subject: Re: [PATCH] don't treat alone grouping pattern as glob qualifier Message-id: <20131118104249.05348e57@pwslap01u.europe.root.pri> In-reply-to: <131117194226.ZM3733@torch.brasslantern.com> References: <20131117052423.GA20827@localhost.localdomain> <131117104041.ZM30561@torch.brasslantern.com> <20131118003043.GA2709@localhost.localdomain> <131117194226.ZM3733@torch.brasslantern.com> Organization: Samsung Cambridge Solution Centre X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu) MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuphluLIzCtJLcpLzFFi42I5/e/4ZV2t951BBt9fi1scbH7I5MDoserg B6YAxigum5TUnMyy1CJ9uwSujOaZP1gK1nNW3Luo2sC4hb2LkZNDQsBEYt6zF1C2mMSFe+vZ QGwhgaWMEneupHQxcgHZy5kk5s3tZAVJsAioSrRf3A7WwCZgKDF102xGEFtEQFzi7NrzLCC2 sICnxKKt08FsXgF7iWnNl5hAbE4BS4lfc7rYIYaeZJRofNTNDJLgF9CXuPr3ExPEFfYSM6+c YYRoFpT4Mfke2CBmAS2JzduaWCFseYnNa94yT2AUmIWkbBaSsllIyhYwMq9iFE0tTS4oTkrP NdIrTswtLs1L10vOz93ECAnBrzsYlx6zOsQowMGoxMOrEdYZJMSaWFZcmXuIUYKDWUmEd8UN oBBvSmJlVWpRfnxRaU5q8SFGJg5OqQZG/cDnEx7u3Z9Z819KXXH/zAe3HRdHiZ7epPH088p1 P4Q//as1OqKw5MAW0Rd8X6M9pygey9A29BZT/v56kZq5wJpO57jcXYd2M65KuesQq9pbniS9 3t6zn1/aVlvHvS3JJLNSPfMS76fnHDV9Vs/v7D/qYGWjXyY2Za5bZYei9a1HthEijnpKLMUZ iYZazEXFiQC7mK/HHwIAAA== On Sun, 17 Nov 2013 19:42:26 -0800 Bart Schaefer wrote: > On Nov 18, 8:30am, Han Pingtian wrote: > } Subject: Re: [PATCH] don't treat alone grouping pattern as glob qualifier > } > } On Sun, Nov 17, 2013 at 10:40:41AM -0800, Bart Schaefer wrote: > } > However, I can't immediately think of any reason why a paren should be > } > considered part of a "trailing set" when nothing precedes it ... > } > } Yes, because there is nothing before (s*), it wouldn't be treated as > } qualifiers, I think. > > Anybody else going to chime in on this? Are there other cases where > the (s == str) test in the patch could be true but the paren really > should be treated as introducing a qualifier? Another relevant factor leading me to suppose this is probably OK is that we don't apply glob qualifiers unless there are files that match, and a file can't match the empty string. So for example (in the Src directory, with NO_NOMATCH, and before the patch although it doesn't affect this): % print signames.c(:t) signames.c % print signames(:t) signames(:t) So I contend there is no case that worked before the patch that fails afterwards. pws