From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-32021-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 5452 invoked by alias); 18 Nov 2013 18:43:35 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 32021
Received: (qmail 13270 invoked from network); 18 Nov 2013 18:43:31 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham
	version=3.3.2
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=spodhuis.org; s=d201210;
	h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=IjJPxZ8SVoGo/Al4s0gJ++O6OcVf2Uxkf1gPC59PrbA=;
	b=IYNF0cWf/VLUZe6SSCExisMjuqZR8uXzDqEZ/9MLxXeI2yV71zFTd40GaXWAh+4uw6hQnihHmcw8V1SdJUO3T/o528dZtlvu0eNXhgLFhWn7zlC1/fsZFc7O7JnNXU9B5Q48gUAZP15aNeypXcaesxOpbzAicsl81UFEsydZ5O8=;
Date: Mon, 18 Nov 2013 10:43:23 -0800
From: Phil Pennock <zsh-workers+phil.pennock@spodhuis.org>
To: Martin Vaeth <vaeth@mathematik.uni-wuerzburg.de>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] helpfiles: Also accept 'UTF-8' as an encoding name.
Message-ID: <20131118184323.GA96085@redoubt.spodhuis.org>
Mail-Followup-To: Martin Vaeth <vaeth@mathematik.uni-wuerzburg.de>,
	zsh-workers@zsh.org
References: <F4421B66-9C9B-4834-ADBF-AB51B886A732@kba.biglobe.ne.jp>
 <slrnl87bph.uko.vaeth@lounge.imp.fu-berlin.de>
 <131113092737.ZM11794@torch.brasslantern.com>
 <slrnl87h62.97t.vaeth@lounge.imp.fu-berlin.de>
 <20131114000658.GA52075@redoubt.spodhuis.org>
 <slrnl89068.2mc.vaeth@lounge.imp.fu-berlin.de>
 <20131114081859.GA64798@redoubt.spodhuis.org>
 <slrnl89bve.89f.vaeth@lounge.imp.fu-berlin.de>
 <7AC8C1DC-EADF-4912-8A68-135B83C7DB8D@kba.biglobe.ne.jp>
 <slrnl8cv7l.d1u.vaeth@lounge.imp.fu-berlin.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <slrnl8cv7l.d1u.vaeth@lounge.imp.fu-berlin.de>
OpenPGP: url=https://www.security.spodhuis.org/PGP/keys/0x3903637F.asc

On 2013-11-15 at 19:58 +0000, Martin Vaeth wrote:
> Got it!  LESSCHARSET=utf-8 was set here which was the culprit.
> So LANG=C seems to work if all LESS* and LC_* variables
> are reset.

Side-note: this highlights that we're reading the output after it has
passed through whichever pager was invoked by man(1), which indicates
there are still stability issues here, if the pager happens to be
something else, such as lv(1) influenced by $LV and a config variable.

> +foreach (keys %ENV) {
> +	delete($ENV{$_}) if(/^((LC_)|(LESS)|(MAN))/);
> +}

You might consider adding after this:

    $ENV{'PAGER'} = 'cat';

to bypass a class of problems here.  (I don't know of any man command
using $VIEWER instead of $PAGER, but perhaps better safe than sorry and
set that too.)

-Phil