Re: Test suite failures on static build (was: 5.0.2-test-2 is available)

[Peter Stephenson <p.stephenson@samsung.com>]

On Mon, 02 Dec 2013 17:16:17 +0100
Axel Beckert <abe@deuxchevaux.org> wrote:
> On Mon, Dec 02, 2013 at 04:01:33PM +0000, Peter Stephenson wrote:
> > On Mon, 02 Dec 2013 16:51:19 +0100
> > Axel Beckert <abe@deuxchevaux.org> wrote:
> > > JFTR: Probably not that important, but I get the following test-suite
> > > failures when doing a static build:
> > > Error output:
> > > (eval):pushd:5: no such file or directory: /home/abe/zsh/zsh/obj-static/testhome
> > > (eval):pushd:9: no such file or directory: /home/abe/zsh/zsh/obj-static/testhome
> > > (eval):popd:10: directory stack empty
> > > Was testing: PUSHD_TO_HOME option
> > 
> > Could the exported value of HOME be funny?
> 
> I don't think so:

Does this patch help anyway?  It leaves less to chance.

It won't help with the first problem, which could also be to do with
directory permissions or similar.

(Kind of me to make all the glob tests here rather brittle.)

diff --git a/Test/E01options.ztst b/Test/E01options.ztst
index e00eb0e..dc3ca4b 100644
--- a/Test/E01options.ztst
+++ b/Test/E01options.ztst
@@ -83,12 +83,13 @@
 %prep
   mkdir options.tmp && cd options.tmp
 
-  mkdir tmpcd
+  mkdir tmpcd homedir
 
   touch tmpfile1 tmpfile2
 
   mydir=$PWD
   mydirt=`print -P %~`
+  mydirhome=`export HOME=$mydir/homedir; print -P %~`
   catpath=$(which cat)
   lspath==ls
 
@@ -513,10 +514,10 @@
   print *(#q:s/#(#b)tmp(*e)/'scrunchy${match[1]}'/)
   unsetopt histsubstpattern
 0:HIST_SUBST_PATTERN option
->TINGcd TINGfile1 TINGfile2
+>TINGcd TINGfile1 TINGfile2 homedir
 >THUMPcd THUMPfile1 THUMPfile2
 >one.c Two.X Three.X
->scrunchyfile1 scrunchyfile2 tmpcd
+>homedir scrunchyfile1 scrunchyfile2 tmpcd
 
   setopt ignorebraces
   echo X{a,b}Y
@@ -853,6 +854,7 @@
 
 # Do you have any idea how dull this is?
 
+  (export HOME=$mydir/homedir
   pushd $mydir/tmpcd
   pushd
   dirs
@@ -863,11 +865,11 @@
   popd
   pushd
   popd
-  dirs
+  dirs)
 0q:PUSHD_TO_HOME option
->$mydirt $mydirt/tmpcd
->~ $mydirt $mydirt/tmpcd
->$mydirt
+>$mydirhome $mydirhome/tmpcd
+>~ $mydirhome $mydirhome/tmpcd
+>$mydirhome
 
   array=(one two three four)
   setopt rcexpandparam


pws